GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser by pablogsal · Pull Request #22077 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Sep 3, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Building with clang 11 and ./configure --with-pydebug --with-address-sanitizer shows no more problems for me

https://bugs.python.org/issue41697

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal pablogsal added the needs backport to 3.9 label Sep 3, 2020
@pablogsal
pablogsal requested a review from lysnikolaou as a code owner September 3, 2020 10:48
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 3, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Sep 3, 2020
@pablogsal pablogsal added skip news and removed awaiting core review labels Sep 3, 2020
@pablogsal
pablogsal requested a review from gvanrossum September 3, 2020 10:49
@pablogsal
pablogsal force-pushed the bpo-41697 branch 2 times, most recently from 8b8b737 to a9fb29d Compare September 3, 2020 11:01
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 3, 2020
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 3, 2020
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 3, 2020
@bedevere-bot

bedevere-bot commented Sep 3, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a9fb29dbdb622487ebc7387e4b3778e157946540 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 3, 2020
@python python deleted a comment from bedevere-bot Sep 3, 2020
@pablogsal
bpo-41697: Correctly handle KeywordOrStarred when parsing arguments i…
e522c80 
…n the parser
@pablogsal
pablogsal force-pushed the bpo-41697 branch from a9fb29d to e522c80 Compare September 3, 2020 14:03
@pablogsal

pablogsal commented Sep 3, 2020

Copy link
Copy Markdown
Member Author

ASAN build of this PR: https://buildbot.python.org/all/#/builders/584/builds/1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Sep 3, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting merge label Sep 3, 2020
@pablogsal
pablogsal merged commit 315a61f into python:master Sep 3, 2020
@miss-islington

miss-islington commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 3, 2020
@pablogsal
pablogsal deleted the bpo-41697 branch September 3, 2020 14:29
@miss-islington

miss-islington commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 315a61f7a9418d904e0eea14b1f054fac3a90e9f 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned pablogsal Sep 3, 2020
pablogsal added a commit to pablogsal/cpython that referenced this pull request Sep 3, 2020
@pablogsal
[3.9] bpo-41697: Correctly handle KeywordOrStarred when parsing argum…
947bd59 
…ents in the parser (pythonGH-22077).

(cherry picked from commit 315a61f)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 3, 2020

Copy link
Copy Markdown

GH-22079 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Sep 3, 2020
pablogsal added a commit that referenced this pull request Sep 3, 2020
@pablogsal
[3.9] bpo-41697: Correctly handle KeywordOrStarred when parsing argum…
be17295 
…ents in the parser (GH-22077) (GH-22079)

(cherry picked from commit 315a61f)

Co-authored-by: Pablo Galindo <[email protected]>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 5, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_41073_add_types…
7537c86 
…lots1

* origin/master: (63 commits)
  bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (pythonGH-22098)
  bpo-38585: Remove references to defusedexpat (pythonGH-22095)
  bpo-41721: Add xlc options (pythonGH-22096)
  bpo-40486: Specify what happens if directory content change diring iteration (pythonGH-22025)
  bpo-41638: Improve ProgrammingError message for absent parameter. (pythonGH-21999)
  bpo-41713: _signal doesn't use multi-phase init (pythonGH-22087)
  bpo-41700: Skip test if the locale is not supported (pythonGH-22081)
  [doc] Update documentation on logging optimization. (pythonGH-22075)
  Fix 'gather' rules in the python parser generator (pythonGH-22021)
  bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser (pythonGH-22077)
  [doc] Fix a typo in the graphlib docs (python#22030)
  bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pythonGH-22049)
  bpo-39883: Use BSD0 license for code in docs (pythonGH-17635)
  bpo-39010: Improve test shutdown (python#22066)
  bpo-41696: Fix handling of debug mode in asyncio.run (python#22069)
  bpo-41690: Use a loop to collect args in the parser instead of recursion (pythonGH-22053)
  closes bpo-41689: Preserve text signature from tp_doc in C heap type creation. (pythonGH-22058)
  Fix invalid escape sequences in the peg_highlight Sphinx extension (pythonGH-22047)
  bpo-41675: Modernize siginterrupt calls (pythonGH-22028)
  bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (pythonGH-22062)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@pablogsal @xzy3-cdc
bpo-41697: Correctly handle KeywordOrStarred when parsing arguments i…
54d6e21 
…n the parser (pythonGH-22077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @bedevere-bot @miss-islington @gvanrossum @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.