GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-42264: Deprecate sqlite3.OptimizedUnicode by erlend-aasland · Pull Request #23163 · python/cpython

Conversation

erlend-aasland commented Nov 5, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Fixes #86430

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Deprecate OptimizedUnicode

af2c7e5

erlend-aasland requested a review from berkerpeksag as a code owner

November 5, 2020 12:30

the-knights-who-say-ni added the CLA signed label

Nov 5, 2020

bedevere-bot added the awaiting review label

Nov 5, 2020

erlend-aasland changed the title ~~bpo-42264: Deprecate OptimizedUnicode~~ bpo-42264: Deprecate sqlite3.OptimizedUnicode

Nov 5, 2020

Erlend E. Aasland added 2 commits

November 5, 2020 13:39


          Add NEWS and update "What's new"

f8dfb6d


          Restore type checks in unit test

f25e85a

serhiy-storchaka approved these changes

Nov 5, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Nov 5, 2020

serhiy-storchaka requested changes

Nov 5, 2020

View reviewed changes

Comment thread

Lib/sqlite3/deprecated.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting changes and removed awaiting merge labels

Nov 5, 2020

bedevere-bot commented Nov 5, 2020

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Address review comment: Refer to caller when warning, and verify this

a9e959f

erlend-aasland commented Nov 5, 2020

Copy link

Copy Markdown

Contributor Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting change review and removed awaiting changes labels

Nov 5, 2020

bedevere-bot commented Nov 5, 2020

Copy link

Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from serhiy-storchaka

November 5, 2020 13:39

serhiy-storchaka approved these changes

Nov 5, 2020

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland and hafizulsaat92 reacted with hooray emoji

All reactions

🎉 2 reactions

bedevere-bot added awaiting merge and removed awaiting change review labels

Nov 5, 2020

erlend-aasland commented Nov 5, 2020

Copy link

Copy Markdown

Contributor Author

Thanks for reviewing, @serhiy-storchaka!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka commented Nov 5, 2020

Copy link

Copy Markdown

Member

And it could be good idea to add tests for filename to all existing deprecation tests.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Nov 5, 2020

Copy link

Copy Markdown

Contributor Author

And it could be good idea to add tests for filename to all existing deprecation tests.

I agree. I can open an issue for it.

serhiy-storchaka reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Nov 5, 2020

Copy link

Copy Markdown

Contributor Author

And it could be good idea to add tests for filename to all existing deprecation tests.

There's a lot:

bash$ grep -r "DeprecationWarning" Lib/test | grep -v " as " | wc -l                                                                                                               (master)cpython.git
     519

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner reviewed

Nov 5, 2020

View reviewed changes

Comment thread

Lib/sqlite3/deprecated.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2020-11-05-13-32-41.bpo-42264.r4KYUU.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend Egeberg Aasland and others added 2 commits

November 5, 2020 20:11


          Address review: Improve NEWS text

3cd247f

Co-authored-by: Victor Stinner <[email protected]>


          Address review: improve "What's new"

b106c9e


          Address review: Move deprecation warning to __init__.py

b364cf5

erlend-aasland commented Nov 5, 2020

Copy link

Copy Markdown

Contributor Author

PTAL, @vstinner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Restore dbapi2 import in __init__.py

3320b42

erlend-aasland commented

Nov 5, 2020

View reviewed changes

Comment thread

Lib/sqlite3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Improve warning wording

62d2e9b

erlend-aasland commented Nov 5, 2020

Copy link

Copy Markdown

Contributor Author

FYI, Ubuntu CI hangs again:
test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner commented Nov 6, 2020

Copy link

Copy Markdown

Member

test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)!

It is a know issue https://bugs.python.org/issue42142

You can ignore it. When it happens, I simply re-run the job until it pass.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner reviewed

Nov 6, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, it's way better! More comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

Comment thread

Misc/NEWS.d/next/Library/2020-11-05-13-32-41.bpo-42264.r4KYUU.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/sqlite3/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland and others added 2 commits

November 6, 2020 20:08


          Address review comment: Improve NEWS entry

2507fd0

Use the same text as the What's New entry.


          Address review comment: Add bpo reference to __init__.py

fe7c65e

Co-authored-by: Victor Stinner <[email protected]>

erlend-aasland commented Nov 6, 2020

Copy link

Copy Markdown

Contributor Author

Please take another look, @vstinner.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner approved these changes

Nov 12, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka: Do you want to double check this PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

erlend-aasland commented Nov 17, 2020

Copy link

Copy Markdown

Contributor Author

@serhiy-storchaka Will you merge this after double checking, or will that be up to another core dev to decide?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Nov 17, 2020

View reviewed changes

serhiy-storchaka merged commit a1f401a into python:master

Nov 17, 2020

bedevere-bot removed the awaiting merge label

Nov 17, 2020

erlend-aasland deleted the bpo-42264 branch

November 17, 2020 19:55

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021


          bpo-42264: Deprecate sqlite3.OptimizedUnicode (pythonGH-23163)

36a56d2

This was referenced May 9, 2022

sqlite3: remove features deprecated in 3.10 #92547

Closed

gh-92547: Remove deprecated sqlite3 features #92548

Merged

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request

May 9, 2022


          pythongh-92547: Remove deprecated sqlite3 features

The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (pythongh-23163)
- sqlite3.enable_shared_cache (pythongh-24008)

Signed-off-by: Erlend E. Aasland <[email protected]>

erlend-aasland added a commit that referenced this pull request

May 16, 2022


          gh-92547: Remove deprecated sqlite3 features (#92548)

00f22e8

The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (gh-23163)
- sqlite3.enable_shared_cache (gh-24008)

Co-authored-by: Jelle Zijlstra <[email protected]>
Signed-off-by: Erlend E. Aasland <[email protected]>

hafizulsaat92 approved these changes

Jul 4, 2025

View reviewed changes

Reviewers

vstinner

vstinner approved these changes

serhiy-storchaka

serhiy-storchaka approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

+1 more reviewer

hafizulsaat92

hafizulsaat92 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Nov 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Nov 5, 2020

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

bedevere-bot commented Nov 5, 2020

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

serhiy-storchaka commented Nov 5, 2020

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

vstinner commented Nov 6, 2020

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Nov 6, 2020

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Nov 17, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erlend-aasland commented Nov 5, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.