GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92547: Remove deprecated sqlite3 features by erlend-aasland · Pull Request #92548 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

  • sqlite3.OptimizedUnicode (bpo-42264: Deprecate sqlite3.OptimizedUnicode #23163)
  • sqlite3.enable_shared_cache (bpo-24464: Deprecate sqlite3.enable_shared_cache #24008)

Signed-off-by: Erlend E. Aasland <[email protected]

Closes #92547

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
gh-92547: Remove deprecated sqlite3 features
8312697 
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (gh-23163)
- sqlite3.enable_shared_cache (gh-24008)

Signed-off-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner May 9, 2022 09:38
@bedevere-bot bedevere-bot added the awaiting core review label May 9, 2022
erlend-aasland added 3 commits May 9, 2022 11:50
@erlend-aasland
Add NEWS
e09fe1a
@erlend-aasland
Use correct issue number for NEWS entry
c3a693f
@erlend-aasland
Add NEWS again; let's see if the CI approves
ef7a0ec
@erlend-aasland
erlend-aasland requested review from JelleZijlstra and serhiy-storchaka May 9, 2022 10:01
JelleZijlstra
JelleZijlstra approved these changes May 10, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 10, 2022
@erlend-aasland

erlend-aasland commented May 13, 2022

Copy link
Copy Markdown
Contributor Author

Code looks good, but let's hold off on merging until the nltk usage of OptimizedUnicode is fixed.

FTR, nltk/nltk#3000 was just merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Merge branch 'main' into sqlite-remove-deprecated-features
b20525f
@JelleZijlstra

JelleZijlstra commented May 16, 2022

Copy link
Copy Markdown
Member

Feel free to merge!
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 00f22e8 into main May 16, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-remove-deprecated-features branch May 16, 2022 17:52
@bedevere-bot bedevere-bot removed the awaiting merge label May 16, 2022
@erlend-aasland

erlend-aasland commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for helping, Jelle and Victor!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
sqlite3: remove features deprecated in 3.10 #92547
Closed
@vstinner

vstinner commented May 17, 2022

Copy link
Copy Markdown
Member

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared: 00f22e8

Would you mind to copy these information in What's New in Python 3.12?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

Removed code contained instructions to port existing code to avoid the deprecation warning: replace OptimizedUnicode with str and use URI with cache=shared: 00f22e8

Would you mind to copy these information in What's New in Python 3.12?

Yes, I'll amend What's New. Thanks for the heads-up!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jun 15, 2022

Copy link
Copy Markdown
Contributor Author

Would you mind to copy these information in What's New in Python 3.12?

Something like this? #93872
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 16, 2022

Copy link
Copy Markdown
Member

Something like this? #93872

That's very valuable, thanks.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
donbarbos added a commit to donbarbos/typeshed that referenced this pull request Mar 29, 2026
@donbarbos
[sqlite3] Deprecate undocumented enable_shared_cache
7d91fcb 
Source: python/cpython#92548
@donbarbos donbarbos mentioned this pull request Mar 29, 2026
[sqlite3] Deprecate undocumented enable_shared_cache python/typeshed#15571
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3: remove features deprecated in 3.10

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @JelleZijlstra @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.