GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-79097: Add support for aggregate window functions in sqlite3 by erlend-aasland · Pull Request #20903 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #79097

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fnep reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner June 15, 2020 21:48
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 15, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jun 15, 2020
@erlend-aasland
erlend-aasland force-pushed the fix-issue-34916 branch from 8374a58 to 04f00e7 Compare November 6, 2020 00:15
@erlend-aasland

erlend-aasland commented Nov 6, 2020

Copy link
Copy Markdown
Contributor Author

Rebased onto master and upgraded with Py_NewRef and intermingled declarations.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland marked this pull request as draft November 17, 2020 22:28
@erlend-aasland

erlend-aasland commented Nov 17, 2020

Copy link
Copy Markdown
Contributor Author

On hold until #23341 is merged
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from f39fc9f to a36a1a5 Compare December 28, 2020 11:58
@erlend-aasland
erlend-aasland force-pushed the fix-issue-34916 branch 10 times, most recently from 9c27690 to b91947d Compare March 10, 2021 13:02
@erlend-aasland
erlend-aasland marked this pull request as ready for review March 10, 2021 13:33
@erlend-aasland erlend-aasland mentioned this pull request Mar 10, 2021
gh-84943: Add support for 'directonly' and 'innocuous' flags for user-defined functions #20398
Closed
@erlend-aasland
erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from 5f17f41 to f1459ed Compare April 18, 2021 22:09
@erlend-aasland
erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from 799bcf6 to 3f052a6 Compare April 23, 2021 09:21
Erlend E. Aasland added 3 commits April 23, 2021 11:24
Erlend E. Aasland
Add support for sqlite3 aggregate window functions
bbef5a4 
See https://docs.python.org/3/library/exceptions.html#NotImplementedError:
It should not be used to indicate that an operator or method is not
meant to be supported at all – in that case either leave the operator /
method undefined or, if a subclass, set it to None.
Erlend E. Aasland
Add NEWS entry
93bfb30
Erlend E. Aasland
Add What's New
7dfeb13
@erlend-aasland
erlend-aasland force-pushed the fix-issue-34916 branch from 3f052a6 to 7dfeb13 Compare April 23, 2021 09:25
@erlend-aasland

erlend-aasland commented Apr 23, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@berkerpeksag Any chance of getting this in before the feature freeze early in the 3.11 dev phase?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title bpo-34916: Add support for aggregate window functions in sqlite3 bpo-79097: Add support for aggregate window functions in sqlite3 Apr 10, 2022
@erlend-aasland erlend-aasland changed the title bpo-79097: Add support for aggregate window functions in sqlite3 gh-79097: Add support for aggregate window functions in sqlite3 Apr 10, 2022
Erlend E. Aasland
Merge branch 'main' into fix-issue-34916
340cea9
@erlend-aasland
erlend-aasland marked this pull request as ready for review April 10, 2022 22:14
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@bedevere-bot

bedevere-bot commented Apr 10, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 340cea9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@erlend-aasland erlend-aasland added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section extension-modules C modules in the Modules dir labels Apr 10, 2022
@bedevere-bot

bedevere-bot commented Apr 10, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 340cea9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@erlend-aasland

erlend-aasland commented Apr 11, 2022

Copy link
Copy Markdown
Contributor Author

@JelleZijlstra, would you like to review this?

FYI, the two buildbot failures look unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra self-requested a review April 11, 2022 16:17
JelleZijlstra
JelleZijlstra reviewed Apr 11, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one requested improvement in the tests.

Let me know if there's other changes you'd like to get in in time for 3.11.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_sqlite3/test_userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra self-assigned this Apr 11, 2022
@erlend-aasland

erlend-aasland commented Apr 11, 2022

Copy link
Copy Markdown
Contributor Author

Let me know if there's other changes you'd like to get in in time for 3.11.

Yes, I've one more feature I'd like to get in: Blob handles, gh-30680 (currently revisiting it, hoping to make it ready for review soon).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Apr 11, 2022

Copy link
Copy Markdown
Member

Yes, I've one more feature I'd like to get in: Blob handles, gh-30680 (currently revisiting it, hoping to make it ready for review soon).

Sounds good, ping me when you're ready.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Address review
431ace8
JelleZijlstra
JelleZijlstra approved these changes Apr 11, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 11, 2022
@JelleZijlstra
JelleZijlstra merged commit 9ebcece into python:main Apr 12, 2022
@BigStone BigStone mannequin mentioned this pull request Apr 10, 2022
Add create_window_function() to sqlite3.Connection #79097
Closed
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 12, 2022
@erlend-aasland

erlend-aasland commented Apr 12, 2022

Copy link
Copy Markdown
Contributor Author

Thanks, @JelleZijlstra! Much appreciated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the fix-issue-34916 branch April 12, 2022 10:35
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 15, 2022
sqlite3: add 3.11 additions python/typeshed#7625
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Apr 15, 2022
@JelleZijlstra
sqlite3: add 3.11 additions
0ba23bb 
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
srittau pushed a commit to python/typeshed that referenced this pull request Apr 16, 2022
@JelleZijlstra
sqlite3: add 3.11 additions (#7625)
d802e65 
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

extension-modules C modules in the Modules dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add create_window_function() to sqlite3.Connection

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @JelleZijlstra @kumaraditya303 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.