GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42035: Add a PyType_GetName() to get type's short name. by shihai1991 · Pull Request #23903 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Dec 23, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue42035

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@shihai1991
Add a PyType_GetName() to get type's name
f98c574
@shihai1991
shihai1991 requested a review from markshannon as a code owner December 23, 2020 05:03
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 23, 2020
@bedevere-bot bedevere-bot added the awaiting review label Dec 23, 2020
@shihai1991
shihai1991 requested review from encukou and vstinner December 23, 2020 05:45
ghost
ghost approved these changes Dec 23, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Dec 23, 2020
encukou
encukou reviewed Jan 5, 2021
View reviewed changes
Comment thread Doc/c-api/type.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 added 3 commits January 6, 2021 00:39
@shihai1991
apply petr's comment
ac19a57
@shihai1991
apply petr's comment
8ec352a
@shihai1991
PyType_GetName return a object
9635bcf
@shihai1991
shihai1991 force-pushed the bpo_42035 branch from 44535d5 to 9635bcf Compare February 2, 2021 18:02
@shihai1991
shihai1991 requested a review from encukou February 5, 2021 01:14
encukou
encukou reviewed Feb 23, 2021
View reviewed changes
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 added 2 commits February 25, 2021 00:38
@shihai1991
calling type_name() in PyType_GetName()
4ba554d
@shihai1991
resolve conflict
facba45
@shihai1991
shihai1991 requested a review from encukou February 25, 2021 16:21
@shihai1991 shihai1991 closed this Feb 26, 2021
@shihai1991 shihai1991 reopened this Feb 26, 2021
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_42035
ad752b9
@shihai1991 shihai1991 changed the title bpo-42035: Add a PyType_GetName() to get type's name. bpo-42035: Add a PyType_GetName() to get type's short name. Jul 20, 2021
@shihai1991

shihai1991 commented Jul 20, 2021

Copy link
Copy Markdown
Member Author

Hi, Petr. Do you think this PR is good enough? @encukou

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shihai1991
shihai1991 force-pushed the bpo_42035 branch 2 times, most recently from c7f03cb to de33627 Compare July 20, 2021 16:32
@shihai1991
shihai1991 requested a review from a team as a code owner July 20, 2021 16:32
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_42035
56e8889
* origin/main: (1146 commits)
  bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155)
  bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249)
  correct spelling (pythonGH-27076)
  bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237)
  bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797)
  Clean up comma usage in Doc/library/functions.rst (python#27083)
  bpo-42238: Fix small rst issue in NEWS.d/. (python#27238)
  bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091)
  bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231)
  bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206)
  bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216)
  bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810)
  bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992)
  bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402)
  bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032)
  bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278)
  bpo-44654: Do not export the union type related symbols (pythonGH-27223)
  bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218)
  bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196)
  bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211)
  ...
@shihai1991
shihai1991 force-pushed the bpo_42035 branch from de33627 to 56e8889 Compare July 20, 2021 18:15
@encukou

encukou commented Jul 23, 2021

Copy link
Copy Markdown
Member

It's on my review list for Tuesday. Apologies for the delay!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shihai1991

shihai1991 commented Jul 24, 2021

Copy link
Copy Markdown
Member Author

It's on my review list for Tuesday. Apologies for the delay!

Get it. Thanks, petr :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou
encukou reviewed Jul 27, 2021
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation & tests look great!
But please, merge in the current main branch add PyType_GetName to stable_abi.txt and regenerate the limited API.
Consider adding PyType_GetQualName as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/c-api/type.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Include/object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@shihai1991

shihai1991 commented Jul 27, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

But please, merge in the current main branch add PyType_GetName to stable_abi.txt and regenerate the limited API.

Get it.

Consider adding PyType_GetQualName as well.

OK. I will use another PR to do it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shihai1991
apply petr's comments
08d3453
@shihai1991
shihai1991 requested a review from encukou July 27, 2021 16:32
@encukou
encukou merged commit a390ebe into python:main Jul 29, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 29, 2021
@shihai1991

shihai1991 commented Jul 29, 2021

Copy link
Copy Markdown
Member Author

Thanks Petr for your review and merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@vstinner vstinner Awaiting requested review from vstinner
@encukou encukou Awaiting requested review from encukou
1 more reviewer
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@shihai1991 @encukou @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.