GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43181: Make PyObject_TypeCheck a static inline function by erlend-aasland · Pull Request #24533 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 15, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue43181

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland added 2 commits February 15, 2021 10:36
Erlend E. Aasland
convert PyObject_TypeCheck to static inline function
23a5701
Erlend E. Aasland
Add NEWS
f3f224d
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 15, 2021
@bedevere-bot bedevere-bot added the awaiting review label Feb 15, 2021
@erlend-aasland

erlend-aasland commented Feb 15, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner Would you mind reviewing this?

(cc. @gpshead )
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Feb 15, 2021
View reviewed changes
Comment thread Include/object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Core and Builtins/2021-02-11-11-37-14.bpo-43181.ydv33S.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend Egeberg Aasland and others added 3 commits February 15, 2021 12:25
Erlend Egeberg Aasland @vstinner
Improve NEWS text
36f742a 
Co-authored-by: Victor Stinner <[email protected]>
Erlend E. Aasland
Address review
b19bf6a 
- Improve naming: Use 'type' iso. 'tp'
- Remove PyAPI_FUNC def
- Remove unneeded parens
Erlend E. Aasland
Fix ReST formatting
ad499ae
@erlend-aasland
erlend-aasland requested a review from vstinner February 15, 2021 11:49
@erlend-aasland

erlend-aasland commented Feb 15, 2021

Copy link
Copy Markdown
Contributor Author

CI is done; PTAL @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 4bb2a1e into python:master Feb 15, 2021
@bedevere-bot bedevere-bot removed the awaiting review label Feb 15, 2021
@erlend-aasland
erlend-aasland deleted the make-pyobject-typecheck-inline branch February 15, 2021 16:22
@erlend-aasland erlend-aasland mentioned this pull request Feb 16, 2021
bpo-40170: Always define PyExceptionClass_Name as a function #24553
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 17, 2021
Erlend E. Aasland
Move pythonGH-24533, pythonGH-24535, and pythonGH-24548 NEWS entries …
c794f9c 
…to "C API" section
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-43181: Convert PyObject_TypeCheck to static inline function (pyth…
50002fc 
…onGH-24533)
@numberZero numberZero mannequin mentioned this pull request Jun 20, 2022
Python macros don’t shield arguments #87347
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.