GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40170: Convert PyDescr_IsData macro to C function by erlend-aasland · Pull Request #24535 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 15, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The macro accessed the PyTypeObject.tp_descr_set member.
Reimplemented as a C function to hide implementation details.

https://bugs.python.org/issue40170

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland added 2 commits February 15, 2021 13:42
Erlend E. Aasland
bpo-40170: Convert PyDescr_IsData macro to a function
7b5a439
Erlend E. Aasland
Add NEWS
dbcef69
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 15, 2021
@bedevere-bot bedevere-bot added the awaiting review label Feb 15, 2021
@erlend-aasland

erlend-aasland commented Feb 15, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner Would you mind reviewing this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Feb 15, 2021
View reviewed changes
Comment thread Include/descrobject.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Core and Builtins/2021-02-15-13-41-14.bpo-40170.r2FAtl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland added 3 commits February 15, 2021 20:37
Erlend E. Aasland
Address review: Improve NEWS entry
c64feb5
Erlend E. Aasland
Add PyDescr_IsData to the limited API
7d71a1a
Erlend E. Aasland
Revert "Add PyDescr_IsData to the limited API"
00b89fd 
This reverts commit 7d71a1a.
vstinner
vstinner approved these changes Feb 16, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 16, 2021
@erlend-aasland

erlend-aasland commented Feb 16, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, @vstinner!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 871eb42 into python:master Feb 16, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 16, 2021
@erlend-aasland
erlend-aasland deleted the bpo-40170/PyDescr_IsData branch February 16, 2021 08:32
@erlend-aasland erlend-aasland mentioned this pull request Feb 16, 2021
bpo-40170: Always define PyExceptionClass_Name as a function #24553
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 17, 2021
Erlend E. Aasland
Move pythonGH-24533, pythonGH-24535, and pythonGH-24548 NEWS entries …
c794f9c 
…to "C API" section
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-40170: Convert PyDescr_IsData() to static inline function (python…
b415fbd 
…GH-24535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @vstinner @encukou @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.