GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — bpo-40170: Always define PyExceptionClass_Name as a function by erlend-aasland · Pull Request #24553 · python/cpython Conversation
|
|
@vstinner Would you mind reviewing this? In related news: The NEWS item section for #24533, #24535, and #24548 were Core and Builtins, but in retrospect I see that C API would have been more fitting. Should I change them? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Right, these changes impact the C API. If these changes were made after the latest Python 3.10 release, you can move the NEWS entries in a new PR. Otherwise, we can leave them, it's not a big deal. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Merged, thanks. The function is only used to display errors, so I don't think that we need to micro-optimize the code (add an internal static inline function, for example), it's not "hot code". I consider that error handling is "cold code". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
All right. I prefer to move them before the next alpha. I'll throw up a PR. Thanks for reviewing 🙏🏻 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…nGH-24553) Remove macro variant of PyExceptionClass_Name().
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.