GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-44839: Raise more specific errors in sqlite3 by serhiy-storchaka · Pull Request #27613 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 5, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

MemoryError raised in user-defined function will now preserve
its type. OverflowError will now be converted to DataError.
Previously both were converted to OperationalError.

https://bugs.python.org/issue44839

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Aug 5, 2021
@serhiy-storchaka
serhiy-storchaka requested a review from erlend-aasland August 5, 2021 12:05
@serhiy-storchaka
serhiy-storchaka requested a review from berkerpeksag as a code owner August 5, 2021 12:05
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 5, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Aug 5, 2021
@serhiy-storchaka
bpo-44839: Raise more specific errors in sqlite3
d7fba66 
MemoryError raised in user-defined function will now preserve
its type. OverflowError will now be converted to DataError.
Previously both were converted to OperationalError.
@serhiy-storchaka
serhiy-storchaka force-pushed the sqlite-python-to-sqlite-errors branch from 99def7f to d7fba66 Compare August 5, 2021 12:07
@erlend-aasland erlend-aasland mentioned this pull request Aug 6, 2021
bpo-42064: Pass module state to sqlite3 UDF callbacks #27456
Merged
erlend-aasland
erlend-aasland requested changes Aug 6, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor adjustments. This is a nice refactoring. These changes will greatly simplify GH-27456. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2021-08-05-14-59-39.bpo-44839.MURNL9.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka and others added 2 commits August 6, 2021 13:48
@serhiy-storchaka Erlend Egeberg Aasland
Update Misc/NEWS.d/next/Library/2021-08-05-14-59-39.bpo-44839.MURNL9.rst
4d6588c 
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@serhiy-storchaka
Merge branch 'main' into sqlite-python-to-sqlite-errors
81fd017
serhiy-storchaka
serhiy-storchaka commented Aug 6, 2021
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review. It is always good to have a second pair of eyes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Address review comments.
1401a84
erlend-aasland
erlend-aasland reviewed Aug 6, 2021
View reviewed changes
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Aug 6, 2021
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka Erlend Egeberg Aasland
Update Modules/_sqlite/connection.c
4de7af8 
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@serhiy-storchaka
serhiy-storchaka merged commit 7d747f2 into python:main Aug 6, 2021
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 6, 2021
@serhiy-storchaka
serhiy-storchaka deleted the sqlite-python-to-sqlite-errors branch August 6, 2021 18:28
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jan 30, 2022
Erlend E. Aasland
Fix test_func_return_too_large_int
28de39f 
pythonGH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.
@erlend-aasland erlend-aasland mentioned this pull request Jan 30, 2022
[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) #31030
Merged
JelleZijlstra pushed a commit that referenced this pull request Feb 21, 2022
Erlend Egeberg Aasland
[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-3…
ba457fe 
…1030)

* [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642).
(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

* Fix test_func_return_too_large_int

GH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 16, 2022
Convert Python exceptions to appropriate SQLite error codes #89002
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.