GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — bpo-43853: Expand test suite for SQLite UDF's by erlend-aasland · Pull Request #27642 · python/cpython Conversation
|
|
FYI: Tests for aggregate functions are already in place (implemented in GH-27588). @serhiy-storchaka, is the refactor commit acceptable? Code coverage is preserved. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Ignore my comments about values which cause errors. I covered them in #27654. But please add more test cases for valid values of different types. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I've updated the PR. PTAL, @serhiy-storchaka. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Resolved: only test arguments passed to UDF's |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@serhiy-storchaka, please take a new look. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I can't; I don't have the commit bit :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
What?! I thought you did. You should. Who's mentoring you? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @erlend-aasland and @gvanrossum, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry @erlend-aasland and @gvanrossum, I had trouble checking out the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I was surprised when I learned that too, I feel like I've seen your name around CPython a lot :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
First @corona10, now @pablogsal 🙂 (BTW, I'll fix the backports.) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I've been around a year or two, IIRC :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
We have already offer the promotion a couple of times, we are working on it 😉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit 3eb3b4f) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-31030 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Backporting to 3.9 from GH-31030. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…1030) * [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642). (cherry picked from commit 3eb3b4f) Co-authored-by: Erlend Egeberg Aasland <[email protected]> * Fix test_func_return_too_large_int GH-27613 (bpo 44839) was not backported, so exceptions differ between main (3.11) and older versions.
…ythonGH-31030) (cherry picked from commit 3eb3b4f)
…ythonGH-31030) (pythonGH-31586) (cherry picked from commit 3eb3b4f)
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.