GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43853: Expand test suite for SQLite UDF's by erlend-aasland · Pull Request #27642 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 6, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Test that strings that contain embedded NULL characters are passed to UDF's
  • Consolidate "test param" tests to reduce the amount of boilerplate code
  • Test more error conditions when building UDF arguments, and returning UDF values
  • Handle PyFloat_AsDouble() errors

https://bugs.python.org/issue43853

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Erlend E. Aasland added 2 commits August 6, 2021 21:37
Erlend E. Aasland
Test that str params with embedded NULL chars are passed to SQLite fu…
1fa7e13
…nctions
Erlend E. Aasland
Refactor most set param tests
aebc9de
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner August 6, 2021 19:43
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 6, 2021
@bedevere-bot bedevere-bot added the awaiting review label Aug 6, 2021
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka August 6, 2021 19:43
@erlend-aasland erlend-aasland added the skip news label Aug 6, 2021
@erlend-aasland

erlend-aasland commented Aug 6, 2021

Copy link
Copy Markdown
Contributor Author

FYI: Tests for aggregate functions are already in place (implemented in GH-27588).

@serhiy-storchaka, is the refactor commit acceptable? Code coverage is preserved.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland added needs backport to 3.9 labels Aug 6, 2021
serhiy-storchaka
serhiy-storchaka reviewed Aug 6, 2021
View reviewed changes
Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka

serhiy-storchaka commented Aug 7, 2021

Copy link
Copy Markdown
Member

Ignore my comments about values which cause errors. I covered them in #27654. But please add more test cases for valid values of different types.

erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
expand test suite and check for PyFloat_AsDouble errors
13f2413
This was referenced Aug 7, 2021
gh-89018: Improve documentation of sqlite3 exceptions #27645
Merged
bpo-44859: Improve error handling in sqlite3 and change some errors #27654
Merged
serhiy-storchaka
serhiy-storchaka reviewed Aug 8, 2021
View reviewed changes
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/sqlite3/test/userfunctions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 2 commits August 8, 2021 22:18
Erlend E. Aasland
Address review: add more tests
3ed9af6
Erlend E. Aasland
Sync with 'main' bco. pythonGH-27654
476edeb
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka August 8, 2021 20:21
@erlend-aasland

erlend-aasland commented Aug 12, 2021

Copy link
Copy Markdown
Contributor Author

I've updated the PR. PTAL, @serhiy-storchaka.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 4 commits August 12, 2021 13:44
Erlend E. Aasland
Test surrogates and non-ascii chars
05c2f80
Erlend E. Aasland
Test 63-bit int with non-zero low bits
21022c2
Erlend E. Aasland
import test.support.gc_collect iso. import gc
0a8ba42
Erlend E. Aasland
Merge branch 'main' into sqlite-test-udf-str-with-null
9f288f1
@erlend-aasland
erlend-aasland marked this pull request as draft September 14, 2021 21:44
@erlend-aasland

erlend-aasland commented Sep 14, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Marked as draft, as I need to resolve some potential issues created by GH-27884.

Resolved: only test arguments passed to UDF's

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 2 commits September 15, 2021 10:15
Erlend E. Aasland
Make test_func_params more specific
02725cf
Erlend E. Aasland
Remove unneeded test UDF
5be2810
@erlend-aasland
erlend-aasland marked this pull request as ready for review September 15, 2021 08:23
@erlend-aasland

erlend-aasland commented Sep 15, 2021

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka, please take a new look.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Jan 26, 2022

Copy link
Copy Markdown
Contributor Author

Go ahead and land it!

I can't; I don't have the commit bit :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum

gvanrossum commented Jan 26, 2022

Copy link
Copy Markdown
Member

What?! I thought you did. You should. Who's mentoring you?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum
gvanrossum merged commit 3eb3b4f into python:main Jan 26, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 26, 2022
@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland and @gvanrossum, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned gvanrossum Jan 26, 2022
@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Sorry @erlend-aasland and @gvanrossum, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra

JelleZijlstra commented Jan 26, 2022

Copy link
Copy Markdown
Member

I can't; I don't have the commit bit :)

I was surprised when I learned that too, I feel like I've seen your name around CPython a lot :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Jan 26, 2022

Copy link
Copy Markdown
Contributor Author

What?! I thought you did. You should. Who's mentoring you?

First @corona10, now @pablogsal 🙂

(BTW, I'll fix the backports.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Jan 26, 2022

Copy link
Copy Markdown
Contributor Author

I was surprised when I learned that too, I feel like I've seen your name around CPython a lot :)

I've been around a year or two, IIRC :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Jan 26, 2022

Copy link
Copy Markdown
Member

What?! I thought you did. You should. Who's mentoring you?

We have already offer the promotion a couple of times, we are working on it 😉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland deleted the sqlite-test-udf-str-with-null branch January 26, 2022 21:12
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jan 26, 2022
Erlend Egeberg Aasland
[3.10] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642).
f0fd0bd
(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jan 30, 2022
@bedevere-bot

bedevere-bot commented Jan 30, 2022

Copy link
Copy Markdown

GH-31030 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland removed the needs backport to 3.9 label Jan 30, 2022
@erlend-aasland

erlend-aasland commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

Backporting to 3.9 from GH-31030.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra JelleZijlstra mentioned this pull request Feb 19, 2022
[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) #31030
Merged
JelleZijlstra pushed a commit that referenced this pull request Feb 21, 2022
Erlend Egeberg Aasland
[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-3…
ba457fe
…1030)

* [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642).
(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

* Fix test_func_return_too_large_int

GH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 25, 2022
Erlend Egeberg Aasland
[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…
b466671
…ythonGH-31030)

(cherry picked from commit 3eb3b4f)
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 26, 2022
Erlend E. Aasland
Adapt pythonGH-27642 tests
d3186be
miss-islington pushed a commit that referenced this pull request Mar 2, 2022
Erlend Egeberg Aasland
[3.9] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030
3ea2a8f
) (GH-31586)

(cherry picked from commit 3eb3b4f)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
Erlend Egeberg Aasland @hello-adam
[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…
3743da6
…ythonGH-31030) (pythonGH-31586)

(cherry picked from commit 3eb3b4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gvanrossum gvanrossum

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@erlend-aasland @serhiy-storchaka @JelleZijlstra @gvanrossum @miss-islington @pablogsal @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.