GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) by erlend-aasland · Pull Request #31030 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jan 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland [email protected]

https://bugs.python.org/issue43853

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend Egeberg Aasland added 2 commits January 26, 2022 22:23
Erlend Egeberg Aasland
[3.10] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642).
f0fd0bd 
(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Erlend E. Aasland
Fix test_func_return_too_large_int
28de39f 
pythonGH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner January 30, 2022 20:00
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 30, 2022
@bedevere-bot bedevere-bot mentioned this pull request Jan 30, 2022
bpo-43853: Expand test suite for SQLite UDF's #27642
Merged
@bedevere-bot bedevere-bot added skip news awaiting review labels Jan 30, 2022
@erlend-aasland

erlend-aasland commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

GH-27613 (bpo 44839) was not backported, so exceptions differ between main and older versions. See 28de39f.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland added the needs backport to 3.9 label Jan 30, 2022
JelleZijlstra
JelleZijlstra approved these changes Feb 19, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 19, 2022
@JelleZijlstra

JelleZijlstra commented Feb 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@gvanrossum I'm planning to merge this (a backport of #27642 which you previously merged after my review). The only non-test changes fix a missed error check for PyFloat_AsDouble, so this should be fine in the bugfix branches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Feb 19, 2022

Copy link
Copy Markdown
Member

+1. If adding tests never caused us to fix any bugs we’d be doing it wrong. :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra self-assigned this Feb 19, 2022
@JelleZijlstra
JelleZijlstra merged commit ba457fe into python:3.10 Feb 21, 2022
@miss-islington

miss-islington commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 21, 2022
@miss-islington

miss-islington commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ba457fe6f8e50ad3ef3ceffb75dee96629a42ad7 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 21, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thanks; I'll fix the 3.9 backport.
JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the backport-3eb3b4f-3.10 branch February 21, 2022 00:55
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 25, 2022
Erlend Egeberg Aasland
[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…
b466671 
…ythonGH-31030)

(cherry picked from commit 3eb3b4f)
@bedevere-bot

bedevere-bot commented Feb 25, 2022

Copy link
Copy Markdown

GH-31586 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Feb 25, 2022
miss-islington pushed a commit that referenced this pull request Mar 2, 2022
Erlend Egeberg Aasland
[3.9] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030
3ea2a8f 
) (GH-31586)

(cherry picked from commit 3eb3b4f)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
Erlend Egeberg Aasland @hello-adam
[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…
3743da6 
…ythonGH-31030) (pythonGH-31586)

(cherry picked from commit 3eb3b4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @JelleZijlstra @gvanrossum @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.