GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable GUI testing on Travis Linux builds via Xvfb by zware · Pull Request #7887 · python/cpython

Conversation

@zware

@zware zware commented Jun 24, 2018

Copy link
Copy Markdown
Member

This enables GUI tests on the Travis Linux builds using xvfb-run. Unfortunately, there's an IDLE test case failing in Travis runs on my fork, which I don't understand and can't reproduce.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware
Enable GUI testing on Travis Linux builds via Xvfb
33fbd38
@zware zware added needs backport to 3.6 tests Tests in the Lib/test dir skip issue skip news labels Jun 24, 2018
@zware
zware requested a review from terryjreedy June 24, 2018 03:12
@bedevere-bot bedevere-bot added the awaiting merge label Jun 24, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 24, 2018
@ammaraskar

ammaraskar commented Jun 24, 2018

Copy link
Copy Markdown
Member

We're already pushing it as far as build times go with the newly added C coverage, let's make sure this isn't cutting it too close to 50 minutes. If so, we might have to split up the coverage build to run half the suite in one build and the other half in another.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ammaraskar

ammaraskar commented Jun 24, 2018

Copy link
Copy Markdown
Member

For reference, 46 minutes on this build! https://travis-ci.org/python/cpython/jobs/395974908
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@taleinat taleinat mentioned this pull request Jun 24, 2018
bpo-33951: IDLE test_configdialog: call page.update() in setUpClass #7892
Merged
@taleinat

taleinat commented Jun 24, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unfortunately, there's an IDLE test case failing in Travis runs on my fork, which I don't understand and can't reproduce.

While investigating that failure I encountered an issue which may or may not be the cause. See bpo-33951 and GH-7892.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 24, 2018

Copy link
Copy Markdown
Member

I am not completely surprised that something fails on Linux. I am more surprised that it failed on Travis and not VSTS Linux (#7890). Cheryl Sabella helped write these tests and must have run them (on Ubuntu) then and since. Tal, do they pass on your Linux?

Is there any easy way to get the tcl/tk version Travis uses? I expanded system info at the top of
https://travis-ci.org/python/cpython/jobs/395980894
and there were lots of things not relevant to us. If nothing else, I could temporarily add a print to test_idle.

Anyway, I am looking into how eq(d.highlight_target.get(), elem[tag]) could possibly have the first item as 'c'. The problem is likely to be in the nested click_it and the event_generate calls. The latter seem to be a bit delicate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@taleinat

taleinat commented Jun 24, 2018

Copy link
Copy Markdown
Contributor

Tal, do they pass on your Linux?

All tests pass on my Ubuntu 16.04 box. I ran the relevant test and all of the IDLE tests, both on current master and on this branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 24, 2018

Copy link
Copy Markdown
Member

Copying the failure here.

FAIL: test_highlight_target_text_mouse (idlelib.idle_test.test_configdialog.HighPageTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/python/cpython/Lib/idlelib/idle_test/test_configdialog.py", line 417, in test_highlight_target_text_mouse
    eq(d.highlight_target.get(), elem[tag])
AssertionError: 'c' != 'Normal Text'
- c
+ Normal Text
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 24, 2018 •
edited by taleinat
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I restarted Travis after merging Tal's fix for bpo-33951 -- and it passes now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware
zware merged commit b12112b into python:master Jul 11, 2018
@miss-islington

miss-islington commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 11, 2018
@zware
zware deleted the travis_gui branch July 11, 2018 19:10
@miss-islington

miss-islington commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Sorry, @zware, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b12112b5ba608cdd7a0962a6b18cad4fe58b46e6 3.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned zware Jul 11, 2018
@miss-islington

miss-islington commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Sorry, @zware, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b12112b5ba608cdd7a0962a6b18cad4fe58b46e6 2.7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

Sorry, @zware, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b12112b5ba608cdd7a0962a6b18cad4fe58b46e6 3.6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jul 14, 2018
@CuriousLearner
Merge branch 'master' into bitwise_docs
11c1706 
* master: (2633 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jul 15, 2018
@CuriousLearner
Merge branch 'master' into fix-issue8525
fdc3a3d 
* master: (1159 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...
zware added a commit to zware/cpython that referenced this pull request Jul 18, 2018
@zware
[3.7] Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887…
661fac9 
…).

(cherry picked from commit b12112b)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Jul 18, 2018
@bedevere-bot

bedevere-bot commented Jul 18, 2018

Copy link
Copy Markdown

GH-8334 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 18, 2018

Copy link
Copy Markdown

GH-8335 is a backport of this pull request to the 3.6 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.6 label Jul 18, 2018
zware added a commit to zware/cpython that referenced this pull request Jul 18, 2018
@zware
[3.6] Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887…
179ea93 
…).

(cherry picked from commit b12112b)

Co-authored-by: Zachary Ware <[email protected]>
zware added a commit to zware/cpython that referenced this pull request Jul 18, 2018
@zware
[2.7] Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887…
5ee0657 
…).

(cherry picked from commit b12112b)

Co-authored-by: Zachary Ware <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 18, 2018

Copy link
Copy Markdown

GH-8336 is a backport of this pull request to the 2.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 2.7 label Jul 18, 2018
zware added a commit that referenced this pull request Jul 20, 2018
@zware
[3.7] Enable GUI testing on Travis Linux builds via Xvfb (GH-7887)
cede1e1 
(cherry picked from commit b12112b)
zware added a commit that referenced this pull request Jul 20, 2018
@zware
[3.6] Enable GUI testing on Travis Linux builds via Xvfb (GH-7887)
226f064 
(cherry picked from commit b12112b)
zware added a commit that referenced this pull request Jul 20, 2018
@zware
[2.7] Enable GUI testing on Travis Linux builds via Xvfb (GH-7887)
c5bc6e4 
(cherry picked from commit b12112b)
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Jul 21, 2018
@CuriousLearner
Merge branch 'master' of github.com:CuriousLearner/cpython into fix-i…
7b039a0 
…ssue-33014

* 'master' of github.com:CuriousLearner/cpython: (722 commits)
  bpo-34087: Fix buffer overflow in int(s) and similar functions (pythonGH-8274)
  bpo-34108: Fix double carriage return in 2to3 on Windows (python#8271)
  bpo-4260: Document that ctypes.xFUNCTYPE are decorators (pythonGH-7924)
  bpo-33723: Fix test_time.test_thread_time() (pythonGH-8267)
  bpo-33967: Remove use of deprecated assertRaisesRegexp() (pythonGH-8261)
  bpo-34080: Fix a memory leak in the compiler. (pythonGH-8222)
  Enable GUI testing on Travis Linux builds via Xvfb (pythonGH-7887)
  bpo-23927: Make getargs.c skipitem() skipping 'w*'. (pythonGH-8192)
  bpo-33648: Remove PY_WARN_ON_C_LOCALE (pythonGH-7114)
  bpo-34092, test_logging: increase SMTPHandlerTest timeout (pythonGH-8245)
  Simplify __all__ in multiprocessing (pythonGH-6856)
  bpo-34083: Update dict order in Functional HOWTO (pythonGH-8230)
  Doc: Point to Simple statements section instead of PEP (pythonGH-8238)
  bpo-29442: Replace optparse with argparse in setup.py (pythonGH-139)
  bpo-33597: Add What's New for PyGC_Head (pythonGH-8236)
  Dataclasses: Fix example on 30.6.8, add method should receive a list rather than an integer. (pythonGH-8038)
  Fix documentation for input and output tutorial (pythonGH-8231)
  bpo-34009: Expand on platform support changes (pythonGH-8022)
  Factor-out two substantially identical code blocks. (pythonGH-8219)
  bpo-34031: fix incorrect usage of self.fail in two tests (pythonGH-8091)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zware zware

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@zware @ammaraskar @taleinat @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.