GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Doc: Disable smartquotes for zh-tw and fr translations. by JulienPalard · Pull Request #9337 · python/cpython

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Sep 15, 2018

Copy link
Copy Markdown
Member

See: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
and: #4006

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JulienPalard
Doc: Disable smartquotes for zh-tw translations.
050c38b 
See: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
and: python#4006
@JulienPalard JulienPalard added skip issue skip news labels Sep 15, 2018
@JulienPalard JulienPalard self-assigned this Sep 15, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 15, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Sep 15, 2018
@JulienPalard

JulienPalard commented Sep 15, 2018

Copy link
Copy Markdown
Member Author

@adrianliaw can you please test a build with this patch and validate it fixes zh-tw quote issues?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard
Doc: Also disable smartquotes for French translations.
dd6d14d 
See: python/python-docs-fr#303
@JulienPalard JulienPalard changed the title Doc: Disable smartquotes for zh-tw translations. Doc: Disable smartquotes for zh-tw and fr translations. Sep 15, 2018
@adrianliaw

adrianliaw commented Sep 17, 2018

Copy link
Copy Markdown
Contributor

It works perfectly for our build. Thank you @JulienPalard for the PR!

As a side note, previously the issue occurred in the translation of tutorial/venv.rst where:

pip has a number of subcommands: “search”, “install”, “uninstall”, “freeze”, etc.

was translated into:

pip 有好幾個子指令："search"、"install"、"uninstall"、"freeze" 等等。

but output as

pip 有好幾個子指令：」search」、」install」、」uninstall」、」freeze」 等等。

Now by applying this PR, this issue doesn't raise again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
willingc
willingc approved these changes Sep 18, 2018
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @JulienPalard. I'll leave this for you to merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@adrianliaw adrianliaw mentioned this pull request Sep 19, 2018
Doc: Disable smartquotes for zh-tw, fr and ja translations #9423
Merged
@JulienPalard JulienPalard added the DO-NOT-MERGE label Oct 10, 2018
@JulienPalard

JulienPalard commented Oct 10, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I prefer the #9423 version, so I close mine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard JulienPalard closed this Oct 10, 2018
@JulienPalard
JulienPalard deleted the smartquotes-zh-tw branch October 10, 2018 12:14
adrianliaw added a commit to adrianliaw/cpython that referenced this pull request Oct 11, 2018
@adrianliaw
Doc: Disable smartquotes for ja, fr and zh_TW translations
9c176a9 
This is a replacement for python#9337.

* Using conf.py to disable smartquotes through Sphinx instead of using docutils.conf
* Disable smartquotes for Japanese, French and Traditional Chinese translations

See:
* Suggesting to use conf.py: https://mail.python.org/pipermail/doc-sig/2018-September/004084.html
* Original smartquotes issue in ja translations: https://bugs.python.org/issue31793
* Disabling for ja: python#4006
* Smartquotes issue in fr: python/python-docs-fr#303
* Smartquotes issue in zh_TW: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JulienPalard JulienPalard

Labels

awaiting merge DO-NOT-MERGE skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JulienPalard @adrianliaw @willingc @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.