GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Doc: Disable smartquotes for zh-tw, fr and ja translations by adrianliaw · Pull Request #9423 · python/cpython

Conversation

@adrianliaw

@adrianliaw adrianliaw commented Sep 19, 2018

Copy link
Copy Markdown
Contributor

This is a replacement for #9337 that uses smartquotes_excludes config in conf.py instead of docutils.conf. See the suggestion in https://mail.python.org/pipermail/doc-sig/2018-September/004084.html

See also: #4006

@JulienPalard Please test a build with this patch and validate if it fixes the smartquotes issue for French translations.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 19, 2018
@bedevere-bot bedevere-bot added the awaiting review label Sep 19, 2018
@JulienPalard JulienPalard added skip issue skip news labels Oct 10, 2018
@JulienPalard

JulienPalard commented Oct 10, 2018

Copy link
Copy Markdown
Member

Tested locally and it works for me. I'll try to get the docs azure builder use the right Sphinx version. We're already using sphinx > 1.7 in production so it's OK.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard

JulienPalard commented Oct 10, 2018

Copy link
Copy Markdown
Member

@adrian Could you bump the sphinx version in .vsts/ and .travis.yml to please the CI?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JulienPalard JulienPalard mentioned this pull request Oct 10, 2018
Doc: Disable smartquotes for zh-tw and fr translations. #9337
Closed
adrianliaw added 3 commits October 11, 2018 18:44
@adrianliaw
Doc: Disable smartquotes for ja, fr and zh_TW translations
9c176a9
This is a replacement for python#9337.

* Using conf.py to disable smartquotes through Sphinx instead of using docutils.conf
* Disable smartquotes for Japanese, French and Traditional Chinese translations

See:
* Suggesting to use conf.py: https://mail.python.org/pipermail/doc-sig/2018-September/004084.html
* Original smartquotes issue in ja translations: https://bugs.python.org/issue31793
* Disabling for ja: python#4006
* Smartquotes issue in fr: python/python-docs-fr#303
* Smartquotes issue in zh_TW: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
@adrianliaw
Doc: Require Sphinx 1.7 to build the documentations (translations)
aa6185d
Using smartquotes_excludes option in conf.py requires Sphinx 1.6.6 or more.

See: http://www.sphinx-doc.org/en/1.7/config.html#confval-smartquotes_excludes
@adrianliaw
Doc: Bump Sphinx version requirements in .azure-pipelines and .travis…
be13af3
….yml to 1.7

Disabling smartquotes in conf.py with Sphinx is available in Sphinx 1.7
thus updating the version requirements for building docs on CI.
@adrianliaw
adrianliaw force-pushed the disable-smartquotes branch from 675534a to be13af3 Compare October 11, 2018 10:46
@adrianliaw

adrianliaw commented Oct 11, 2018

Copy link
Copy Markdown
Contributor Author

@JulienPalard Done!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JulienPalard added 3 commits November 3, 2018 19:39
@JulienPalard
Merge branch 'master' into disable-smartquotes
2f0feea
@JulienPalard
Restore removed line in merge.
33a0fd4
@JulienPalard
Adding zh_CN while we're at it.
89bb421
@JulienPalard
JulienPalard merged commit c03bf0a into python:master Nov 4, 2018
@bedevere-bot bedevere-bot removed the awaiting review label Nov 4, 2018
JulienPalard pushed a commit to JulienPalard/cpython that referenced this pull request Nov 5, 2018
@adrianliaw @JulienPalard
Doc: Disable smartquotes for zh-tw, zh-cn, fr and ja translations (py…
6b2d9b3
…thonGH-9423)

(cherry picked from commit c03bf0a)
miss-islington pushed a commit that referenced this pull request Dec 9, 2018
@JulienPalard @miss-islington
[3.7] Doc: Disable smartquotes for zh-tw, zh-cn, fr and ja translatio…
b6b7795
…ns (GH-9423) (GH-10344)

(cherry picked from commit c03bf0a)
@AA-Turner AA-Turner mentioned this pull request Oct 19, 2024
Use the latest Sphinx version #125722
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@adrianliaw @JulienPalard @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.