GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs by jiajunjie · Pull Request #97662 · python/cpython

Conversation

@jiajunjie

@jiajunjie jiajunjie commented Sep 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: sqlite3.Cursor.fetchone may return an object returned by row_factory #97661

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jiajunjie
Add a return value in sqlite3.Cursor.fetchone document
962f75b
@jiajunjie
jiajunjie requested review from berkerpeksag and erlend-aasland as code owners September 30, 2022 01:59
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 30, 2022
@erlend-aasland erlend-aasland added 3.11 only security fixes 3.10 (EOL) end of life labels Oct 3, 2022
@erlend-aasland

erlend-aasland commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Thanks. Please update the PR to also improve the accuracy of the fetchmany and fetchall docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland reviewed Oct 3, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland @CAM-Gerlach
Apply CAM's suggestion
9d228e7
Co-authored-by: C.A.M. Gerlach <[email protected]>
@erlend-aasland

erlend-aasland commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Thanks. Please update the PR to also improve the accuracy of the fetchmany and fetchall docs.

I changed my mind; let's keep this PR narrow.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland approved these changes Oct 5, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 5, 2022
@erlend-aasland erlend-aasland linked an issue Oct 5, 2022 that may be closed by this pull request
sqlite3.Cursor.fetchone may return an object returned by row_factory #97661
Closed
@erlend-aasland erlend-aasland changed the title gh-97661: Add a return value in sqlite3.Cursor.fetchone document gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs Oct 5, 2022
@erlend-aasland erlend-aasland self-assigned this Oct 5, 2022
@erlend-aasland
erlend-aasland merged commit 4b83cd0 into python:main Oct 5, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 5, 2022
@erlend-aasland erlend-aasland added needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 5, 2022
@miss-islington

miss-islington commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @jiajunjie for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @jiajunjie for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland removed 3.11 only security fixes 3.10 (EOL) end of life labels Oct 5, 2022
@bedevere-bot

bedevere-bot commented Oct 5, 2022

Copy link
Copy Markdown

GH-97899 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@jiajunjie @miss-islington
pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (pyt…
1913fb0
…honGH-97662)

Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 5, 2022

Copy link
Copy Markdown

GH-97900 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@jiajunjie @miss-islington
pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (pyt…
70b62b2
…honGH-97662)

Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Oct 5, 2022
sqlite3.Cursor.fetchone may return an object returned by row_factory #97661
Closed
miss-islington added a commit that referenced this pull request Oct 5, 2022
@miss-islington @jiajunjie
gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (GH-97662)
3c09deb
Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <[email protected]>
miss-islington added a commit that referenced this pull request Oct 5, 2022
@miss-islington @jiajunjie
gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (GH-97662)
79b5c1a
Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
4bb5d9d
* main: (66 commits)
  pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)
  docs(typing): add "see PEP 675" to LiteralString (python#97926)
  pythongh-97850: Remove all known instances of module_repr() (python#97876)
  I changed my surname early this year (python#96671)
  pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)
  pythongh-91539: improve performance of get_proxies_environment  (python#91566)
  build(deps): bump actions/stale from 5 to 6 (python#97701)
  pythonGH-95172 Make the same version `versionadded` oneline (python#95172)
  pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)
  pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)
  pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)
  pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383)
  pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759)
  pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251)
  pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662)
  pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644)
  pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756)
  pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778)
  pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826)
  Add re.VERBOSE flag documentation example (python#97678)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@jiajunjie @CAM-Gerlach @mpage
pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (pyt…
45b9d05
…hon#97662)

Co-authored-by: C.A.M. Gerlach <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @jiajunjie @pablogsal
gh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (GH-97662)
5f43097
Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit 4b83cd0)

Co-authored-by: Jia Junjie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3.Cursor.fetchone may return an object returned by row_factory

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jiajunjie @erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.