GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args by akulakov · Pull Request #97826 · python/cpython

Conversation

@akulakov

@akulakov akulakov commented Oct 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: AttributeError calling subprocess.check_output(input=None) with encoding or errors args #97825

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@akulakov
fix AttributeError, add unit test
7da32ba
@akulakov
akulakov requested a review from gpshead as a code owner October 4, 2022 07:44
@bedevere-bot bedevere-bot added the awaiting review label Oct 4, 2022
blurb-it Bot and others added 2 commits October 4, 2022 07:55
@blurb-it
📜🤖 Added by blurb_it.
547db4c
@akulakov
Update 2022-10-04-07-55-19.gh-issue-97825.mNdv1l.rst
1129f49
JelleZijlstra
JelleZijlstra approved these changes Oct 4, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right and mirrors the logic at

cpython/Lib/subprocess.py

Line 904 in 4f380db

self.text_mode = encoding or errors or text or universal_newlines
for deciding whether to use text mode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 4, 2022
gpshead
gpshead approved these changes Oct 5, 2022
View reviewed changes
@gpshead gpshead added needs backport to 3.10 needs backport to 3.11 only security fixes type-bug An unexpected behavior, bug, or error labels Oct 5, 2022
@gpshead
gpshead merged commit db64fb9 into python:main Oct 5, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 5, 2022
@miss-islington

miss-islington commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @akulakov for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 5, 2022
@bedevere-bot

bedevere-bot commented Oct 5, 2022

Copy link
Copy Markdown

GH-97880 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@akulakov @miss-islington
pythongh-97825: fix AttributeError when calling subprocess.check_outp…
537a90f
…ut(input=None) with encoding or errors args (pythonGH-97826)

* fix AttributeError, add unit test
(cherry picked from commit db64fb9)

Co-authored-by: andrei kulakov <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 5, 2022

Copy link
Copy Markdown

GH-97881 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@akulakov @miss-islington
pythongh-97825: fix AttributeError when calling subprocess.check_outp…
b771e84
…ut(input=None) with encoding or errors args (pythonGH-97826)

* fix AttributeError, add unit test
(cherry picked from commit db64fb9)

Co-authored-by: andrei kulakov <[email protected]>
miss-islington added a commit that referenced this pull request Oct 5, 2022
@miss-islington @akulakov
gh-97825: fix AttributeError when calling subprocess.check_output(inp…
9133aab
…ut=None) with encoding or errors args (GH-97826)

* fix AttributeError, add unit test
(cherry picked from commit db64fb9)

Co-authored-by: andrei kulakov <[email protected]>
miss-islington added a commit that referenced this pull request Oct 5, 2022
@miss-islington @akulakov
gh-97825: fix AttributeError when calling subprocess.check_output(inp…
ece5f7e
…ut=None) with encoding or errors args (GH-97826)

* fix AttributeError, add unit test
(cherry picked from commit db64fb9)

Co-authored-by: andrei kulakov <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
4bb5d9d
* main: (66 commits)
  pythongh-65961: Raise `DeprecationWarning` when `__package__` differs from `__spec__.parent` (python#97879)
  docs(typing): add "see PEP 675" to LiteralString (python#97926)
  pythongh-97850: Remove all known instances of module_repr() (python#97876)
  I changed my surname early this year (python#96671)
  pythongh-93738: Documentation C syntax (:c:type:<C type> -> :c:expr:<C type>) (python#97768)
  pythongh-91539: improve performance of get_proxies_environment  (python#91566)
  build(deps): bump actions/stale from 5 to 6 (python#97701)
  pythonGH-95172 Make the same version `versionadded` oneline (python#95172)
  pythongh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (python#32073)
  pythongh-93738: Documentation C syntax (Function glob patterns -> literal markup) (python#97774)
  pythongh-93357: Port test cases to IsolatedAsyncioTestCase, part 2 (python#97896)
  pythongh-95196: Disable incorrect pickling of the C implemented classmethod descriptors (pythonGH-96383)
  pythongh-97758: Fix a crash in getpath_joinpath() called without arguments (pythonGH-97759)
  pythongh-74696: Pass root_dir to custom archivers which support it (pythonGH-94251)
  pythongh-97661: Improve accuracy of sqlite3.Cursor.fetchone docs (python#97662)
  pythongh-87092: bring compiler code closer to a preprocessing-opt-assembler organisation (pythonGH-97644)
  pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_exception_handler() (python#96756)
  pythongh-93738: Documentation C syntax (:c:type:`PyTypeObject*` -> :c:expr:`PyTypeObject*`) (python#97778)
  pythongh-97825: fix AttributeError when calling subprocess.check_output(input=None) with encoding or errors args (python#97826)
  Add re.VERBOSE flag documentation example (python#97678)
  ...
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@akulakov @mpage
pythongh-97825: fix AttributeError when calling subprocess.check_outp…
2efca9c
…ut(input=None) with encoding or errors args (python#97826)

* fix AttributeError, add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@akulakov @miss-islington @bedevere-bot @gpshead @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.