GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97781: Apply changes from importlib_metadata 5. by jaraco · Pull Request #97785 · python/cpython

Conversation

@jaraco

@jaraco jaraco commented Oct 3, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Adopt changes from importlib_metadata 5 #97781

This PR also includes the docs updates from importlib_metadata 4.x.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jaraco
pythongh-97781: Apply changes from importlib_metadata 5.
49b5db9
@jaraco
jaraco requested a review from warsaw as a code owner October 3, 2022 17:25
@bedevere-bot bedevere-bot added the awaiting core review label Oct 3, 2022
@jaraco

jaraco commented Oct 3, 2022

Copy link
Copy Markdown
Member Author

@CAM-Gerlach I could use your help on this one - after applying the docs changes in importlib_metadata and applying them here, they lead to some docs build failures. Could you help come up with a patch that would address these failures?
warsaw reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco added the sprint label Oct 3, 2022
@warsaw

warsaw commented Oct 3, 2022

Copy link
Copy Markdown
Member

I was going to review the live branch built docs but I'm getting the same build error, which I also don't understand.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach
CAM-Gerlach reviewed Oct 3, 2022
View reviewed changes
Comment thread Doc/library/importlib.metadata.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
jaraco added 2 commits October 5, 2022 15:17
@jaraco
Apply changes from upstream
5df1c55
@jaraco
Apply changes from upstream.
1692bf4
@jaraco

jaraco commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

Docs build errors are fixed now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco merged commit 8af04cd into python:main Oct 6, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 6, 2022
@jaraco
jaraco deleted the gh-97781/importlib_metadata_5 branch October 6, 2022 19:25
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
e5d2169 
* main:
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
  pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
jaraco added a commit to python/importlib_metadata that referenced this pull request Oct 7, 2022
@jaraco
Hard-code links to packaging docs until intersphinx is supported. Ref p…
5cf4adb 
…ython/cpython#97785.
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
415ed49 
* main:
  pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996)
  pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984)
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@jaraco @mpage
pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785
d68c84f 
)

* pythongh-97781: Apply changes from importlib_metadata 5.

* Apply changes from upstream

* Apply changes from upstream.
@jaraco jaraco mentioned this pull request Oct 30, 2022
BUG: [py3.11] AttributeError: 'PathDistribution' object has no attribute '_normalized_name' #98706
Closed
jaraco added a commit to python/importlib_metadata that referenced this pull request Oct 30, 2022
@jaraco
Hard-code links to packaging docs until intersphinx is supported. Ref p…
e8d8f9d 
…ython/cpython#97785.
@jaraco jaraco mentioned this pull request Dec 2, 2022
Update Python versions in the CI workflow. python/miss-islington#590
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

sprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jaraco @warsaw @CAM-Gerlach @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.