GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96078: os.sched_yield release the GIL while calling sched_yield(2). by corona10 · Pull Request #97965 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Oct 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: The os.sched_yield() implementation in posixmodule.c doesn't release the GIL #96078

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
corona10 requested a review from vstinner October 6, 2022 15:47
@bedevere-bot bedevere-bot added the awaiting core review label Oct 6, 2022
@corona10

corona10 commented Oct 6, 2022

Copy link
Copy Markdown
Member Author 

(.oss) corona10@python-dev:~/cpython$ ./python -m test test_posix -R 3:3
0:00:00 load avg: 0.02 Run tests sequentially
0:00:00 load avg: 0.02 [1/1] test_posix
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 9.1 sec
Tests result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Oct 6, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-96078: os.sched_yield release the GIL while calling sched_yi…
40c5725 
…eld(2).
@corona10
corona10 force-pushed the gh-96078 branch from 5f150a8 to 40c5725 Compare October 6, 2022 22:03
@benjaminp
benjaminp merged commit b9d2e81 into python:main Oct 6, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 6, 2022
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
e5d2169 
* main:
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
  pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
@corona10
corona10 deleted the gh-96078 branch October 7, 2022 00:34
@corona10 corona10 added needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 7, 2022
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 7, 2022

Copy link
Copy Markdown

GH-98013 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 7, 2022
@bedevere-bot

bedevere-bot commented Oct 7, 2022

Copy link
Copy Markdown

GH-98014 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@corona10 @miss-islington
fixes pythongh-96078: os.sched_yield release the GIL while calling sc…
920e025 
…hed_yield(2). (pythongh-97965)

(cherry picked from commit b9d2e81)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@corona10 @miss-islington
fixes pythongh-96078: os.sched_yield release the GIL while calling sc…
4a38944 
…hed_yield(2). (pythongh-97965)

(cherry picked from commit b9d2e81)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @corona10
fixes gh-96078: os.sched_yield release the GIL while calling sched_yi…
e39b511 
…eld(2). (gh-97965)

(cherry picked from commit b9d2e81)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @corona10
fixes gh-96078: os.sched_yield release the GIL while calling sched_yi…
11945f2 
…eld(2). (gh-97965)

(cherry picked from commit b9d2e81)

Co-authored-by: Dong-hee Na <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
415ed49 
* main:
  pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996)
  pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984)
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@corona10 @mpage
fixes pythongh-96078: os.sched_yield release the GIL while calling sc…
0c970bd 
…hed_yield(2). (pythongh-97965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @miss-islington @bedevere-bot @kumaraditya303 @benjaminp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.