GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-65961: Deprecate `__cached__` by brettcannon · Pull Request #97990 · python/cpython

Conversation

@brettcannon

@brettcannon brettcannon commented Oct 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Rely on __spec__.cached in all cases.

  • Issue: update the import machinery to only use __spec__ #65961

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brettcannon added 4 commits October 6, 2022 10:58
@brettcannon
pythongh-65961: do not rely solely on __cached__
139c8ce 
Make sure `__spec__.cached` (at minimum) can be used.
@brettcannon
Add a news entry
b1c4e2a
@brettcannon
Update What's New
2541729
@brettcannon
Merge branch 'main' of https://github.com/python/cpython into depreca…
2d4ad1d 
…te-__cached__
@brettcannon
brettcannon requested a review from warsaw October 6, 2022 19:36
@bedevere-bot bedevere-bot added the awaiting core review label Oct 6, 2022
@brettcannon brettcannon mentioned this pull request Oct 6, 2022
update the import machinery to only use __spec__ #65961
Open
brettcannon added 4 commits October 6, 2022 13:43
@brettcannon
Merge branch 'main' into deprecate-__cached__
e1269dc
@brettcannon
Link to ModuleSpec in versionchanged notices
e8f74e4
@brettcannon
Merge branch 'deprecate-__cached__' of https://github.com/brettcannon…
3e88550 
…/cpython into deprecate-__cached__
@brettcannon
Merge branch 'main' into deprecate-__cached__
5fd8b61
warsaw
warsaw approved these changes Oct 6, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 6, 2022
@brettcannon
Merge branch 'main' into deprecate-__cached__
f9f03d8
@brettcannon
brettcannon merged commit e1c4d56 into python:main Oct 6, 2022
@brettcannon
brettcannon deleted the deprecate-__cached__ branch October 6, 2022 22:40
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 6, 2022
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
e5d2169 
* main:
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
  pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
415ed49 
* main:
  pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996)
  pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984)
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@brettcannon @mpage
pythongh-65961: Do not rely solely on __cached__ (pythonGH-97990)
7064cd5 
Make sure `__spec__.cached` (at minimum) can be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@brettcannon @warsaw @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.