GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-95914: Add What's New item describing PEP 670 changes by CAM-Gerlach · Pull Request #98315 · python/cpython

Conversation

CAM-Gerlach commented Oct 16, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Part of #95914 (and in turn, #95913).

As discussed with @erlend-aasland , adds an item to the C API -> Porting section of the Python 3.11 What's New document summarizing the changes proposed in PEP 670 (PEP-670), Converting macros to functions in the Python C API, and implemented by @vstinner in issue #89653 (and many linked PRs) and their impact on users. This is the last chunk needed before I can link every Summary item with a more detailed What's New entry, and then #95914 will finally be complete.

Issue: List and document remaining significant PEPs in What's New in 3.11 #95914

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add item to C API porting section describing PEP 670 changes

b1a4d4c

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Oct 16, 2022

CAM-Gerlach requested review from erlend-aasland, ezio-melotti and vstinner

October 16, 2022 03:45

CAM-Gerlach added 3.11

only security fixes

topic-C-API needs backport to 3.11 only security fixes labels

Oct 16, 2022

This was referenced Oct 16, 2022

List and document remaining significant PEPs in What's New in 3.11 #95914

Closed

Edit What's New for Python 3.11 #95913

Closed

JelleZijlstra approved these changes

Oct 16, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Oct 16, 2022

erlend-aasland approved these changes

Oct 17, 2022

View reviewed changes

erlend-aasland commented Oct 17, 2022

Copy link

Copy Markdown

Contributor

LGTM, and thanks for doing this! I have compiled a list of commit refs and macro names; we could throw them in (at least the macro names) but I'm not sure the added verbosity is worth it, as the list is long.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Oct 17, 2022

Copy link

Copy Markdown

Contributor

Let's wait for @vstinner's thumbs up before merging.

CAM-Gerlach reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner reviewed

Oct 17, 2022

View reviewed changes

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 reviewed

Oct 17, 2022

View reviewed changes

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach commented

Oct 17, 2022

View reviewed changes

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply requested changes from Victor and Kumar to PEP 670 section

8fad67c

Co-authored-by: Victor Stinner <[email protected]>

CAM-Gerlach requested review from kumaraditya303 and vstinner

October 17, 2022 17:51

vstinner approved these changes

Oct 17, 2022

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach reacted with hooray emoji

All reactions

🎉 1 reaction

vstinner merged commit aafc53c into python:main

Oct 17, 2022

miss-islington commented Oct 17, 2022

Copy link

Copy Markdown

Contributor

Thanks @CAM-Gerlach for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Oct 17, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 17, 2022


          pythongh-95914: Add What's New item describing PEP 670 changes (pytho…

284511a

…nGH-98315)

(cherry picked from commit aafc53c)

Co-authored-by: C.A.M. Gerlach <[email protected]>

bedevere-bot commented Oct 17, 2022

Copy link

Copy Markdown

GH-98365 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Oct 17, 2022

miss-islington added a commit that referenced this pull request

Oct 17, 2022


          gh-95914: Add What's New item describing PEP 670 changes (GH-98315)

f4a0b80

(cherry picked from commit aafc53c)

Co-authored-by: C.A.M. Gerlach <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Oct 17, 2022


          Merge branch 'main' into typewatch

cdbe93b

* main: (31 commits)
  pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345)
  pythongh-95914: Add What's New item describing PEP 670 changes (python#98315)
  Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358)
  pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316)
  pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333)
  pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001)
  pythongh-97669: Create Tools/build/ directory (python#97963)
  pythongh-95534: Improve gzip reading speed by 10% (python#97664)
  pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344)
  pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336)
  pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929)
  pythongh-85525: Remove extra row in doc (python#98337)
  pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457)
  pythongh-97527: IDLE - fix buggy macosx patch (python#98313)
  pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319)
  pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158)
  pythonGH-94597: Deprecate child watcher getters and setters (python#98215)
  pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255)
  Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294)
  [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290)
  ...

pablogsal pushed a commit that referenced this pull request

Oct 22, 2022


          gh-95914: Add What's New item describing PEP 670 changes (GH-98315)

715b677

(cherry picked from commit aafc53c)

Co-authored-by: C.A.M. Gerlach <[email protected]>

Reviewers

vstinner

vstinner approved these changes

JelleZijlstra

JelleZijlstra approved these changes

erlend-aasland

erlend-aasland approved these changes

ezio-melotti

Awaiting requested review from ezio-melotti

kumaraditya303

Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.11

only security fixes

docs

Documentation in the Doc dir

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

CAM-Gerlach commented Oct 16, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Oct 17, 2022

Uh oh!

erlend-aasland commented Oct 17, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Oct 17, 2022

Uh oh!

bedevere-bot commented Oct 17, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CAM-Gerlach commented Oct 16, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.