GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98307: Add docstring and documentation for SysLogHandler.createSocket (GH-98319) by vsajip · Pull Request #98319 · python/cpython

Conversation

@vsajip

@vsajip vsajip commented Oct 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Logging: SysLogHandler.createSocket added in 3.11 but not documented #98307

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach reacted with hooray emoji
All reactions
  • 🎉 1 reaction
vsajip added 2 commits October 16, 2022 06:13
@vsajip
pythongh-98307: Add docstring and documentation for SysLogHandler.cre…
0eb2f90
…ateSocket
@vsajip
Add NEWS entry.
d02a81a
@vsajip vsajip added the docs Documentation in the Doc dir label Oct 16, 2022
@vsajip vsajip self-assigned this Oct 16, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Oct 16, 2022
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes labels Oct 16, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 16, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
@vsajip
vsajip requested a review from CAM-Gerlach October 16, 2022 05:39
CAM-Gerlach
CAM-Gerlach reviewed Oct 16, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks. Thanks for your work and the super quick response, @vsajip !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/logging/handlers.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/logging.handlers.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

vsajip and others added 3 commits October 16, 2022 06:48
@vsajip @CAM-Gerlach
Improved phrasing
483bea7
Co-authored-by: C.A.M. Gerlach <[email protected]>
@vsajip @CAM-Gerlach
Improved phrasing and annotation added
cee3a76
Co-authored-by: C.A.M. Gerlach <[email protected]>
@vsajip
Remove trailing whitespace.
bf52ab1
CAM-Gerlach
CAM-Gerlach approved these changes Oct 16, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vsajip

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CAM-Gerlach

CAM-Gerlach commented Oct 16, 2022

Copy link
Copy Markdown
Member

@pablogsal , please make sure to backport this if you could, so the function is documented and the links in the What's New added in #98320 work. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsajip vsajip changed the title gh-98307: Add docstring and documentation for SysLogHandler.createSocket gh-98307: Add docstring and documentation for SysLogHandler.createSocket (GH-98319) Oct 16, 2022
@vsajip
vsajip merged commit f6b1e40 into python:main Oct 16, 2022
@vsajip
vsajip deleted the fix-98307 branch October 16, 2022 08:15
@miss-islington

miss-islington commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting core review label Oct 16, 2022
@miss-islington

miss-islington commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

Sorry @vsajip, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f6b1e4048dc353aecfbfbae07de8212900632098 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vsajip added a commit to vsajip/cpython that referenced this pull request Oct 16, 2022
@vsajip
[3.11] pythongh-98307: Add docstring and documentation for SysLogHand…
489d3ed
…ler.createSocket (pythonGH-98319)

Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit f6b1e40)

Co-authored-by: Vinay Sajip <[email protected]>
@vsajip vsajip mentioned this pull request Oct 16, 2022
[3.11] gh-98307: Add docstring and documentation for SysLogHandler.cr… (GH-98325) #98325
Merged
carljm added a commit to carljm/cpython that referenced this pull request Oct 17, 2022
@carljm
Merge branch 'main' into typewatch
cdbe93b
* main: (31 commits)
  pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345)
  pythongh-95914: Add What's New item describing PEP 670 changes (python#98315)
  Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358)
  pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316)
  pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333)
  pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001)
  pythongh-97669: Create Tools/build/ directory (python#97963)
  pythongh-95534: Improve gzip reading speed by 10% (python#97664)
  pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344)
  pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336)
  pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929)
  pythongh-85525: Remove extra row in doc (python#98337)
  pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457)
  pythongh-97527: IDLE - fix buggy macosx patch (python#98313)
  pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319)
  pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158)
  pythonGH-94597: Deprecate child watcher getters and setters (python#98215)
  pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255)
  Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294)
  [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290)
  ...
@hauntsaninja hauntsaninja removed the needs backport to 3.11 only security fixes label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vsajip vsajip

Labels

3.11 only security fixes docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vsajip @CAM-Gerlach @miss-islington @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.