GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Pass `name` to `asyncio.create_task` by harshil21 · Pull Request #3759 · python-telegram-bot/python-telegram-bot

Conversation

@harshil21

@harshil21 harshil21 commented Jun 17, 2023

Copy link
Copy Markdown
Member

Closes #3733

I couldn't test the name in Job._run since that task is instantly awaited (why?)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
harshil21 added 2 commits June 17, 2023 17:18
@harshil21
Give tasks names and test them
7cca8a4
@harshil21
add versionadded
0dcdd54
@harshil21 harshil21 added enhancement 🔗 python related technology: python labels Jun 17, 2023
@harshil21 harshil21 added this to the v20.4 milestone Jun 17, 2023
@harshil21 harshil21 linked an issue Jun 17, 2023 that may be closed by this pull request
Adopt Py3.8+ features: Names for asyncio tasks #3733
Closed
@Bibo-Joshi

Bibo-Joshi commented Jun 17, 2023

Copy link
Copy Markdown
Member

@harshil21 IISC the point is that the call to application.create_task ensures that the job will be awaited on shutdown...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@harshil21
attempt to fix tests on windows
e239911 
by using Event based test than a timed one
@harshil21 harshil21 added the 📋 pending-review work status: pending-review label Jun 20, 2023
Bibo-Joshi
Bibo-Joshi reviewed Jun 20, 2023
View reviewed changes

@Bibo-Joshi Bibo-Joshi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! :) Left a few suggestions below. Sorry for the brief wording, I'm not at a keyboard...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
harshil21 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread telegram/ext/_application.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread telegram/ext/_application.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread telegram/ext/_conversationhandler.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread telegram/ext/_jobqueue.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@harshil21
Review: Rename task names to include bot id
44314ef
@harshil21 harshil21 removed the 📋 pending-review work status: pending-review label Jun 20, 2023
@harshil21 harshil21 mentioned this pull request Jun 22, 2023
[FEATURE] Provide a "official" string representation for most classes #3770
Closed
Bibo-Joshi
Bibo-Joshi reviewed Jun 25, 2023
View reviewed changes
Comment thread telegram/ext/_application.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread telegram/ext/_application.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
harshil21 and others added 3 commits June 25, 2023 19:14
@harshil21
Review: forgot to remove part of task name
db1423c
@Bibo-Joshi
Merge branch 'drop-py-37' into asyncio-task-names
ec068e1
@Bibo-Joshi
Merge branch 'drop-py-37' into asyncio-task-names
e1546aa
@harshil21 harshil21 added the 📋 pending-merge work status: pending-merge label Jun 28, 2023
@Bibo-Joshi
Bibo-Joshi merged commit 59a932a into drop-py-37 Jun 29, 2023
@Bibo-Joshi
Bibo-Joshi deleted the asyncio-task-names branch June 29, 2023 15:47
@Bibo-Joshi Bibo-Joshi removed the 📋 pending-merge work status: pending-merge label Jun 29, 2023
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jun 29, 2023
Drop Support for Python 3.7 #3728
Merged
9 of 17 tasks
Bibo-Joshi added a commit that referenced this pull request Jun 29, 2023
@Bibo-Joshi @harshil21
@Trifase @thefunkycat @clot27 @lemontree210
Drop Support for Python 3.7 (#3728, #3742, #3749, #3740, #3754, #3753, …
fb86bb3 
…#3764, #3762, #3759)

Co-authored-by: Harshil <[email protected]>
Co-authored-by: Luca Bellanti <[email protected]>
Co-authored-by: thefunkycat <[email protected]>
Co-authored-by: Aditya Yadav <[email protected]>
Co-authored-by: Dmitry Kolomatskiy <[email protected]>
clot27 added a commit that referenced this pull request Jul 3, 2023
@Bibo-Joshi @harshil21
@Trifase @thefunkycat @clot27 @lemontree210 Aditya
Drop Support for Python 3.7 (#3728, #3742, #3749, #3740, #3754, #3753, …
52ce1a4 
…#3764, #3762, #3759)

Co-authored-by: Harshil <[email protected]>
Co-authored-by: Luca Bellanti <[email protected]>
Co-authored-by: thefunkycat <[email protected]>
Co-authored-by: Aditya Yadav <[email protected]>
Co-authored-by: Dmitry Kolomatskiy <[email protected]>
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2023
@Bibo-Joshi Bibo-Joshi added 🔌 enhancement pr description: enhancement and removed enhancement labels Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Bibo-Joshi Bibo-Joshi Bibo-Joshi left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

🔌 enhancement pr description: enhancement 🔗 python related technology: python

Projects

None yet

Milestone

v20.4

Development

Successfully merging this pull request may close these issues.

Adopt Py3.8+ features: Names for asyncio tasks

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@harshil21 @Bibo-Joshi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.