GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||
GeezerVison is showing github.com — fix(short-input): hide selected text to prevent overlay collision by octo-patch · Pull Request #4318 · simstudioai/sim Conversation
Contributor
SummaryFixes #3389 When users selected text in a Root cause: Fix: Add Type of Change
Changes
Testing
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
…ership workflow edits via sockets, ui improvements …ng improvements, posthog, secrets mutations …ration, signup method feature flags, SSO improvements * feat(posthog): Add tracking on mothership abort (simstudioai#4023) Co-authored-by: Theodore Li <[email protected]> * fix(login): fix captcha headers for manual login (simstudioai#4025) * fix(signup): fix turnstile key loading * fix(login): fix captcha header passing * Catch user already exists, remove login form captcha …nts, secrets performance, polling refactors, drag resources in mothership …y invalidation, HITL docs …endar triggers, docs updates, integrations/models pages improvements …ions, jira forms endpoints …mat, logs performance improvements fix(csp): add missing analytics domains, remove unsafe-eval, fix workspace CSP gap (simstudioai#4179) fix(landing): return 404 for invalid dynamic route slugs (simstudioai#4182) improvement(seo): optimize sitemaps, robots.txt, and core web vitals across sim and docs (simstudioai#4170) fix(gemini): support structured output with tools on Gemini 3 models (simstudioai#4184) feat(brightdata): add Bright Data integration with 8 tools (simstudioai#4183) fix(mothership): fix superagent credentials (simstudioai#4185) fix(logs): close sidebar when selected log disappears from filtered list; cleanup (simstudioai#4186) v0.6.46: mothership streaming fixes, brightdata integration …m integration, atlassian triggers …rity hardening, contact page, 404 page, access control, SES, SNS v0.6.54: migration error logs …ze, subagent thinking, files sorting, agentphone integration fix(db): revert statement_timeout startup options breaking pooled connections (simstudioai#4284) v0.6.57: mothership reliability, ashby refactor, tables row count, copilot id fix, bun upgrade The ShortInput component uses a transparent input layer beneath a formatted overlay. When users selected text and scrolled horizontally, the browser's ::selection pseudo-element overrode `color: transparent`, making raw unformatted text visible and causing visual collision with the overlay. Adding `selection:text-transparent` keeps the input text invisible under selection, while the overlay continues to display the correctly formatted highlighted text. Fixes simstudioai#3389 Co-Authored-By: Octopus <[email protected]>
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
PR SummaryLow Risk Overview This updates the input styling to also make Reviewed by Cursor Bugbot for commit 9c8e51e. Bugbot is set up for automated code reviews on this repo. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Greptile SummaryThis PR fixes a visual bug in Confidence Score: 5/5Safe to merge — single-line, non-breaking CSS fix with no logic changes. The change is a one-line Tailwind class addition that directly addresses the described bug without touching any logic, state, or APIs. The fix correctly targets the No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant I as Input (text-transparent)
participant O as Overlay div (formatted text)
U->>I: Types text
I->>O: Sync scroll position (handleScroll)
O->>U: Renders formatted/highlighted text
Note over U,I: User selects text + scrolls
I-->>U: Before fix — ::selection overrides color, raw text bleeds through overlay
I-->>U: After fix — selection:text-transparent keeps color transparent during selection
Reviews (1): Last reviewed commit: "fix(short-input): hide selected text to ..." | Re-trigger Greptile |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29606901 | Triggered | Generic High Entropy Secret | a54dcbe | apps/sim/providers/utils.test.ts | View secret |
To avoid such incidents in the future consider
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@octo-patch please rebase against origin staging. Thanks for the contribution! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Resolved conflicts: - user-input.tsx: kept HEAD's mention-menu logic (syncMentionState, mentionRangeRef, useCallback handleInputChange) over staging's simplified inline handleInputChange - short-input.tsx: kept HEAD's selection:text-transparent fix from #4318 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
9c8e51e2
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
[BUG] Short Input Component Text Distortion on selection
There was an error while loading. Please reload this page.