GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix #117: Only open tds/twb inside archives by t8y8 · Pull Request #118 · tableau/document-api-python

Conversation

@t8y8

@t8y8 t8y8 commented Dec 8, 2016

Copy link
Copy Markdown
Contributor

Fixes #117 and verified with a test.

Tableau 9.0 added workbooks that can have an external file cache embedded in the archive. Those workbooks have .key and .bin files. .key files are valid XML and there was a bug in the find_file_in_zip method that would return the first valid XML file it found. Now we only iterate over .twb or /tds files and try to open them (we still validate the root element a layer up). This fixes the bug and should be a little bit faster since we won't be opening as many files.

@RussTheAerialist is probably still out but maybe @LGraber can fill in.

(I'm also pretty confidant in the fix, it's small, tested, and I wrote all the original code in this file anyway :) )

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@t8y8
Fix #117 by only attempting files with the right extension inside the…
2f028cb 
… archive
@t8y8
t8y8 requested a review from LGraber December 8, 2016 20:52
@t8y8
t8y8 merged commit fb36a3a into tableau:development Dec 12, 2016
@t8y8

t8y8 commented Dec 12, 2016

Copy link
Copy Markdown
Contributor Author

I'm bad, but I wanted the fix in so #117 can be unblocked. I'll owe @RussTheAerialist a drink :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@t8y8
t8y8 deleted the 117-fix-cached-twbx branch December 12, 2016 02:47
@graysonarts

graysonarts commented Dec 12, 2016

Copy link
Copy Markdown
Contributor

Dang it @t8y8, as long as it's coffee.
t8y8 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
graysonarts pushed a commit that referenced this pull request Jan 11, 2017
Russell Hay
Release 0.6 (#126)
65fbc80 
* Fix #117 by only attempting files with the right extension inside the archive (#118)

* Commenting and Docstring cleanup. A few very small code cleanups (#120)

Add docstrings and remove clutter. I also made some very tiny tweaks to some code for clarity.

* Small cleanups for various editors. Play nice with built in test-runners (#121)

* Add Py36, update travis to use pycodestyle (#124)

* Add `initial sql` and `query band` support (#123)

Addresses #109 and #110

* Prep for release of 0.6 (#125)

* Prep for release of 0.6

* wordsmithing the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LGraber LGraber Awaiting requested review from LGraber

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@t8y8 @graysonarts
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.