GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Small cleanups for various editors. Play nice with built in test-runners by t8y8 · Pull Request #121 · tableau/document-api-python

Conversation

t8y8 commented Dec 15, 2016

Copy link

Copy Markdown

Contributor

Add Sublime and VSCode settings files to the gitignore
The init in the test folder makes a lot of test runners angry because it imports some packages it doesn't need to. By removing that I can make some ides happier. This has no effect on setup.py test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Small cleanups for various editors. Play nice with built in test-runners

a91a68f

t8y8 requested review from LGraber, benlower and jz-huang

December 15, 2016 02:04

jz-huang approved these changes

Dec 15, 2016

View reviewed changes

jz-huang left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good =)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jz-huang commented Dec 15, 2016

Copy link

Copy Markdown

🚀

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

t8y8 merged commit cdccd2f into tableau:development

Dec 15, 2016

t8y8 deleted the minor-touchup branch

December 15, 2016 02:10

graysonarts pushed a commit that referenced this pull request

Jan 11, 2017


          Release 0.6 (#126)

65fbc80

* Fix #117 by only attempting files with the right extension inside the archive (#118)

* Commenting and Docstring cleanup. A few very small code cleanups (#120)

Add docstrings and remove clutter. I also made some very tiny tweaks to some code for clarity.

* Small cleanups for various editors. Play nice with built in test-runners (#121)

* Add Py36, update travis to use pycodestyle (#124)

* Add `initial sql` and `query band` support (#123)

Addresses #109 and #110

* Prep for release of 0.6 (#125)

* Prep for release of 0.6

* wordsmithing the changelog

Reviewers

benlower

Awaiting requested review from benlower

LGraber

Awaiting requested review from LGraber

1 more reviewer

jz-huang

jz-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.