GeezerVison is showing static-codereview.wikimedia.org — r82219 MediaWiki - Code Review archive
r82219 MediaWiki - Code Review archive
| Repository: | MediaWiki |
| Revision: | < r82218 | r82219 | r82220 > |
| Date: | 07:19, 16 February 2011 |
| Author: | catrope |
| Status: | ok (Comments)
|
| Tags: | |
| Comment: | ( bug 27302) Don't append the current timestamp for user/site modules when no user/site JS/CSS is present. Was caused by 1 being rounded down to 0, which is interpreted as 'now' by wfTimestamp(). This revision just drops timestamp rounding because it's not used consistently anyway |
| Modified paths: |
- /trunk/phase3/includes/OutputPage.php (modified) (history)
|
| Index: trunk/phase3/includes/OutputPage.php |
| — | — | @@ -2496,7 +2496,7 @@ |
| 2497 | 2497 | $timestamp = max( $timestamp, $module->getModifiedTime( $context ) ); |
| 2498 | 2498 | } |
| 2499 | 2499 | // Add a version parameter so cache will break when things change |
| 2500 | | - $query['version'] = wfTimestamp( TS_ISO_8601_BASIC, round( $timestamp, -2 ) ); |
| | 2500 | + $query['version'] = wfTimestamp( TS_ISO_8601_BASIC, $timestamp ); |
| 2501 | 2501 | } |
| 2502 | 2502 | // Make queries uniform in order |
| 2503 | 2503 | ksort( $query ); |
Follow-up revisions
| Revision | Commit summary | Author | Date |
|---|
| r82220 | 1.17wmf1: MFT r80495, r80765, r81177, r82000, r82155, r82156, r82191, r82200,... | catrope | 07:23, 16 February 2011 |
| r82248 | 1.17wmf1: MFT r82219, r82247 | catrope | 14:30, 16 February 2011 |
| r82468 | (bug 27302) Avoid unnecessary requests for user and site modules if the relev... | catrope | 17:07, 19 February 2011 |
| r85151 | MFT: r82000, r82004, r82020, r82025, r82038, r82039, r82048, r82070, r82081, ... | demon | 20:39, 1 April 2011 |
Comments
Status & tagging log
- 20:40, 1 April 2011 😂 (talk | contribs) changed the tags for r82219 [removed: 1.17]
- 19:13, 29 March 2011 😂 (talk | contribs) changed the status of r82219 [removed: new added: ok]
- 07:24, 16 February 2011 Catrope (talk | contribs) changed the tags for r82219 [removed: 1.17wmf1]
- 07:20, 16 February 2011 Catrope (talk | contribs) changed the tags for r82219 [added: 1.17,1.17wmf1]
|
