GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Add snowflake support for date & number with scale by sfc-gh-madkins · Pull Request #3148 · feast-dev/feast

Conversation

sfc-gh-madkins commented Aug 28, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Signed-off-by: Miles Adkins [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot added the size/S label

Aug 28, 2022

sfc-gh-madkins added needs-ok-to-test do-not-merge/work-in-progress labels

Aug 28, 2022

codecov-commenter commented Aug 28, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.12%. Comparing base (9f78367) to head (cf6abc4).
⚠️ Report is 1647 commits behind head on master.

Files with missing lines	Patch %	Lines
...on/feast/infra/materialization/snowflake_engine.py	66.66%	1 Missing ⚠️
...hon/feast/infra/offline_stores/snowflake_source.py	66.66%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
+ Coverage   67.11%   76.12%   +9.01%     
==========================================
  Files         175      211      +36     
  Lines       15905    17858    +1953     
==========================================
+ Hits        10675    13595    +2920     
+ Misses       5230     4263     -967

Flag	Coverage Δ
integrationtests	`66.94% <66.66%> (-0.18%)`	⬇️
unittests	`58.27% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sfc-gh-madkins force-pushed the snowflake_date_dtype branch from 9d72cc7 to e695bd4 Compare

August 28, 2022 21:47


          feat: Add snowflake support for date & number with scale

cf6abc4

Signed-off-by: Miles Adkins <[email protected]>

sfc-gh-madkins force-pushed the snowflake_date_dtype branch from e695bd4 to cf6abc4 Compare

August 28, 2022 21:59

achals approved these changes

Aug 29, 2022

View reviewed changes

achals left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned achals

Aug 29, 2022

feast-ci-bot added the lgtm label

Aug 29, 2022

feast-ci-bot commented Aug 29, 2022

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added the approved label

Aug 29, 2022

sfc-gh-madkins removed the do-not-merge/work-in-progress label

Aug 29, 2022

feast-ci-bot merged commit 50e8755 into feast-dev:master

Aug 29, 2022

sfc-gh-madkins deleted the snowflake_date_dtype branch

August 29, 2022 22:04

felixwang9817 pushed a commit that referenced this pull request

Sep 20, 2022


          chore(release): release 0.25.0

769c318

# [0.25.0](v0.24.0...v0.25.0) (2022-09-20)

### Bug Fixes

* Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082))
* Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20))
* Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630))
* Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25))
* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5))
* Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b))
* Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf))
* Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca))
* Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018))
* Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9))
* Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff))

### Features

* Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2))
* Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c))
* Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2))
* Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755))
* Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3))
* Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211))
* Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))

Reviewers

achals

achals approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

achals

Labels

approved lgtm needs-ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error: "Snowflake Data Type is not supported" on "NUMBER" with non-zero scale

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sfc-gh-madkins commented Aug 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Aug 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

achals left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Aug 29, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sfc-gh-madkins commented Aug 28, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov-commenter commented Aug 28, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.