GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Feature-server image is missing mysql dependency for mysql registry by ptran32 · Pull Request #3223 · feast-dev/feast

Conversation

ptran32 commented Sep 15, 2022

Copy link

Copy Markdown

Contributor

Signed-off-by: [email protected] [email protected]

Author: [email protected] [email protected]

What this PR does / why we need it:
This PR is need to fix feast-feature-server (using helm chart) that can't connect to mysql as registry. (see issue below for more details)

Add mysqlclient in order to use mysql as registry
Add it to requirements.txt and also moved pip install feast in it
Which issue(s) this PR fixes:

Fixes #3218

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot added the size/XS label

Sep 15, 2022

ptran32 changed the title ~~add requirements.txt and add mysqlclient package~~ fix: Feature-server image is missing mysql dependency for mysql registry

Sep 15, 2022

ptran32 force-pushed the add_mysqlclient_to_dockerfile branch from 153ce3f to ede54fb Compare

September 15, 2022 17:13

ptran32 mentioned this pull request

Sep 15, 2022

feast-feature-server can't connect to mysql as registry #3218

Closed

adchia reviewed

Sep 15, 2022

View reviewed changes

Comment thread

sdk/python/feast/infra/feature_servers/multicloud/requirements.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

adchia commented Sep 15, 2022

Copy link

Copy Markdown

Collaborator

/ok-to-test

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added the ok-to-test label

Sep 15, 2022

ptran32 added 3 commits

September 15, 2022 13:58


          add requirements.txt and add mysqlclient package

2a3aa18

Signed-off-by: [email protected] <[email protected]>

Author:    [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>


          use feast[mysql] in requirements.txt

8e7b331

Signed-off-by: [email protected] <[email protected]>


          add feast components

1b60833

Signed-off-by: [email protected] <[email protected]>

ptran32 force-pushed the add_mysqlclient_to_dockerfile branch from 9d5d0bf to 1b60833 Compare

September 15, 2022 17:59

codecov-commenter commented Sep 15, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Base: 67.49% // Head: 77.01% // Increases project coverage by +9.51% 🎉

Coverage data is based on head (6b283a6) compared to base (a59c33a).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3223      +/-   ##
==========================================
+ Coverage   67.49%   77.01%   +9.51%     
==========================================
  Files         179      213      +34     
  Lines       16358    18232    +1874     
==========================================
+ Hits        11041    14041    +3000     
+ Misses       5317     4191    -1126

Flag	Coverage Δ
integrationtests	`67.57% <ø> (+0.07%)`	⬆️
unittests	`58.27% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...on/feast/infra/materialization/snowflake_engine.py	`92.13% <0.00%> (-0.46%)`	⬇️
sdk/python/feast/infra/offline_stores/snowflake.py	`94.14% <0.00%> (-0.33%)`	⬇️
...tion/contrib/spark/spark_materialization_engine.py	`71.84% <0.00%> (-0.28%)`	⬇️
...ffline_stores/contrib/athena_repo_configuration.py	`100.00% <0.00%> (ø)`
...s/contrib/mssql_offline_store/tests/data_source.py	`46.93% <0.00%> (ø)`
...ores/contrib/trino_offline_store/trino_type_map.py	`6.66% <0.00%> (ø)`
...ine_stores/contrib/cassandra_repo_configuration.py	`100.00% <0.00%> (ø)`
...ontrib/postgres_offline_store/tests/data_source.py	`51.02% <0.00%> (ø)`
...s/contrib/postgres_offline_store/tests/__init__.py	`100.00% <0.00%> (ø)`
...hon/feast/infra/utils/postgres/connection_utils.py	`48.00% <0.00%> (ø)`
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

achals approved these changes

Sep 15, 2022

View reviewed changes

achals left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned achals

Sep 15, 2022

feast-ci-bot added lgtm approved labels

Sep 15, 2022

achals reviewed

Sep 15, 2022

View reviewed changes

Comment thread

sdk/python/feast/infra/feature_servers/multicloud/Dockerfile Resolved

Uh oh!

There was an error while loading. Please reload this page.


          add native libraries needed by mysqlclient

6b283a6

Signed-off-by: [email protected] <[email protected]>

feast-ci-bot added size/S and removed lgtm size/XS labels

Sep 15, 2022

achals approved these changes

Sep 15, 2022

View reviewed changes

achals left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot added the lgtm label

Sep 15, 2022

feast-ci-bot commented Sep 15, 2022

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, ptran32

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot merged commit ae37b20 into feast-dev:master

Sep 15, 2022

ptran32 deleted the add_mysqlclient_to_dockerfile branch

September 16, 2022 12:59

felixwang9817 pushed a commit that referenced this pull request

Sep 20, 2022


          chore(release): release 0.25.0

769c318

# [0.25.0](v0.24.0...v0.25.0) (2022-09-20)

### Bug Fixes

* Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082))
* Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20))
* Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630))
* Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25))
* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5))
* Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b))
* Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf))
* Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca))
* Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018))
* Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9))
* Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff))

### Features

* Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2))
* Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c))
* Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2))
* Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755))
* Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3))
* Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211))
* Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))

felixwang9817 mentioned this pull request

Sep 21, 2022

fix: Build dockerfile correctly #3239

Merged

Reviewers

adchia

adchia left review comments

achals

achals approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

achals

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ptran32 commented Sep 15, 2022

Uh oh!

Uh oh!

adchia commented Sep 15, 2022

Uh oh!

codecov-commenter commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

achals left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

achals left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Sep 15, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Sep 15, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.