GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add ability to give boto extra args for registry config by mzwiessele · Pull Request #3219 · feast-dev/feast

Conversation

@mzwiessele

@mzwiessele mzwiessele commented Sep 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Give the ability to add extra arguments to the boto3 put_object method when using the S3 registry.
We use this feature to enable ServerSideEncryption=AES256 if required by our buckets.
For example: feature_store.yaml:

...
registry:
    path: s3://my-bucket/registry.db
    boto_extra_args:
        ServerSideEncryption: AES256
...

Which issue(s) this PR fixes:

N/A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mzwiessele
feature: add ability to give boto extra args in config
4b461df 
Signed-off-by: Max Z <[email protected]>
@feast-ci-bot feast-ci-bot added the size/XS label Sep 15, 2022
@mzwiessele mzwiessele changed the title feat: add ability to give boto extra args for registry config feat: Add ability to give boto extra args for registry config Sep 15, 2022
@mzwiessele

mzwiessele commented Sep 15, 2022

Copy link
Copy Markdown
Contributor Author

/assign @tsotnet
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot assigned tsotnet Sep 15, 2022
@mzwiessele
rename: s3_additional_kwargs
74a7422 
Signed-off-by: Max Z <[email protected]>
@codecov-commenter

codecov-commenter commented Sep 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Base: 67.03% // Head: 76.43% // Increases project coverage by +9.39% 🎉

Coverage data is based on head (74a7422) compared to base (7bc1dff).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3219      +/-   ##
==========================================
+ Coverage   67.03%   76.43%   +9.39%     
==========================================
  Files         175      213      +38     
  Lines       15948    18271    +2323     
==========================================
+ Hits        10691    13965    +3274     
+ Misses       5257     4306     -951
Flag Coverage Δ
integrationtests 67.32% <100.00%> (+0.28%) ⬆️
unittests 58.28% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/registry/s3.py 81.96% <100.00%> (+0.30%) ⬆️
sdk/python/feast/repo_config.py 87.92% <100.00%> (+5.41%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 65.99% <0.00%> (-20.86%) ⬇️
...k/python/feast/infra/offline_stores/file_source.py 86.98% <0.00%> (-7.56%) ⬇️
sdk/python/feast/infra/offline_stores/snowflake.py 93.72% <0.00%> (-0.75%) ⬇️
...on/feast/infra/materialization/snowflake_engine.py 92.13% <0.00%> (-0.46%) ⬇️
...line_stores/contrib/athena_offline_store/athena.py 38.50% <0.00%> (ø)
...ores/contrib/trino_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
...ontrib/postgres_offline_store/tests/data_source.py 51.02% <0.00%> (ø)
...tores/contrib/trino_offline_store/trino_queries.py 15.05% <0.00%> (ø)
... and 110 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@felixwang9817
felixwang9817 self-requested a review September 20, 2022 02:30
@felixwang9817 felixwang9817 assigned felixwang9817 and unassigned tsotnet Sep 20, 2022
felixwang9817
felixwang9817 approved these changes Sep 20, 2022
View reviewed changes

@felixwang9817 felixwang9817 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot added the lgtm label Sep 20, 2022
@feast-ci-bot

feast-ci-bot commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, mzwiessele

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot added the approved label Sep 20, 2022
@felixwang9817

felixwang9817 commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

thanks for the PR @mzwiessele!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot
feast-ci-bot merged commit fbc6a2c into feast-dev:master Sep 20, 2022
felixwang9817 pushed a commit that referenced this pull request Sep 20, 2022
@feast-ci-bot
chore(release): release 0.25.0
769c318 
# [0.25.0](v0.24.0...v0.25.0) (2022-09-20)

### Bug Fixes

* Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082))
* Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20))
* Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630))
* Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25))
* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5))
* Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b))
* Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf))
* Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca))
* Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018))
* Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9))
* Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff))

### Features

* Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2))
* Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c))
* Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2))
* Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755))
* Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3))
* Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211))
* Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))
@mzwiessele
mzwiessele deleted the boto3_extra_args branch September 20, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mzwiessele @codecov-commenter @feast-ci-bot @felixwang9817 @tsotnet
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.