GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Fix Shopify timestamp bug and add warnings to help with debugging entity registration by kevjumba · Pull Request #3191 · feast-dev/feast

Conversation

kevjumba commented Sep 7, 2022

Copy link

Copy Markdown

Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3189 #3188

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kevjumba added 2 commits

September 7, 2022 14:16

Fix

86d3d31

Signed-off-by: Kevin Zhang <[email protected]>


          Foix lint

a1fc535

Signed-off-by: Kevin Zhang <[email protected]>

feast-ci-bot added approved size/XS labels

Sep 7, 2022

kevjumba added ok-to-test and removed size/XS labels

Sep 7, 2022

achals reviewed

Sep 7, 2022

View reviewed changes

achals left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg. Tests?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

felixwang9817 approved these changes

Sep 7, 2022

View reviewed changes

felixwang9817 left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned felixwang9817

Sep 7, 2022

feast-ci-bot commented Sep 7, 2022

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [felixwang9817,kevjumba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added the lgtm label

Sep 7, 2022

codecov-commenter commented Sep 7, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Base: 67.03% // Head: 75.69% // Increases project coverage by +8.65% 🎉

Coverage data is based on head (a1fc535) compared to base (b4ef834).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3191      +/-   ##
==========================================
+ Coverage   67.03%   75.69%   +8.65%     
==========================================
  Files         175      211      +36     
  Lines       15941    17927    +1986     
==========================================
+ Hits        10686    13569    +2883     
+ Misses       5255     4358     -897

Flag	Coverage Δ
integrationtests	`66.85% <50.00%> (-0.18%)`	⬇️
unittests	`57.90% <50.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/type_map.py	`57.14% <0.00%> (+0.78%)`	⬆️
sdk/python/feast/feature_view.py	`96.91% <100.00%> (+1.91%)`	⬆️
...on/feast/infra/materialization/snowflake_engine.py	`92.13% <0.00%> (-0.46%)`	⬇️
sdk/python/feast/infra/provider.py	`77.94% <0.00%> (ø)`
sdk/python/feast/infra/passthrough_provider.py	`96.29% <0.00%> (ø)`
...s/contrib/trino_offline_store/tests/data_source.py	`17.64% <0.00%> (ø)`
.../online_stores/contrib/hbase_online_store/hbase.py	`37.25% <0.00%> (ø)`
...stores/contrib/trino_offline_store/trino_source.py	`5.37% <0.00%> (ø)`
...s/contrib/mssql_offline_store/tests/data_source.py	`46.93% <0.00%> (ø)`
...offline_stores/contrib/mssql_repo_configuration.py	`100.00% <0.00%> (ø)`
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot merged commit de75971 into feast-dev:master

Sep 7, 2022

adchia pushed a commit that referenced this pull request

Sep 8, 2022


          fix: Fix Shopify timestamp bug and add warnings to help with debuggin…

95066ea

…g entity registration (#3191)

* Fix

Signed-off-by: Kevin Zhang <[email protected]>

* Foix lint

Signed-off-by: Kevin Zhang <[email protected]>

Signed-off-by: Kevin Zhang <[email protected]>

adchia pushed a commit that referenced this pull request

Sep 8, 2022


          chore(release): release 0.24.1

d71fc97

## [0.24.1](v0.24.0...v0.24.1) (2022-09-08)

### Bug Fixes

* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([5dba4a3](5dba4a3))
* Fix release workflow ([#3144](#3144)) ([c77a655](c77a655))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([95066ea](95066ea))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([0e13573](0e13573))

felixwang9817 pushed a commit that referenced this pull request

Sep 20, 2022


          chore(release): release 0.25.0

769c318

# [0.25.0](v0.24.0...v0.25.0) (2022-09-20)

### Bug Fixes

* Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082))
* Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20))
* Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630))
* Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25))
* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5))
* Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b))
* Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf))
* Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca))
* Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018))
* Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9))
* Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff))

### Features

* Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2))
* Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c))
* Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2))
* Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755))
* Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3))
* Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211))
* Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))

Reviewers

achals

achals left review comments

felixwang9817

felixwang9817 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

felixwang9817

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Materialization fails if a timestamp column is full of np.NaNs

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

kevjumba commented Sep 7, 2022

Uh oh!

achals left a comment

Choose a reason for hiding this comment

Uh oh!

felixwang9817 left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Sep 7, 2022

Uh oh!

codecov-commenter commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Sep 7, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.