GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build,win: distribute the install-tools scripts in the zip by refack · Pull Request #24233 · nodejs/node

Conversation

@refack

@refack refack commented Nov 7, 2018

Copy link
Copy Markdown
Contributor
  • pack install-tools.* into the zip
  • reroute MSI files sources
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@refack refack added windows Issues and PRs related to the Windows platform. install Issues and PRs related to installing Node.js and its installers. build Issues and PRs related to Node.js builds or CI infrastructure. labels Nov 7, 2018
@refack
refack requested review from bzoz, joaocgreis and richardlau November 7, 2018 21:46
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2018

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1530/pipeline

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 7, 2018
@refack refack added semver-minor PRs that contain new features and should be released in the next minor version. and removed tools Issues and PRs related to the tools directory. labels Nov 7, 2018
@refack refack mentioned this pull request Nov 7, 2018
Does not complete installation felixrieseberg/windows-build-tools#150
Open
richardlau
richardlau approved these changes Nov 7, 2018
View reviewed changes
jasnell
jasnell approved these changes Nov 10, 2018
View reviewed changes
joaocgreis
joaocgreis suggested changes Nov 10, 2018
View reviewed changes

@joaocgreis joaocgreis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack the changes make sense, thanks! If you could test your changes locally before pushing, that would probably save us review cycles.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread vcbuild.bat Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tools/msvs/msi/product.wxs Resolved

Uh oh!

There was an error while loading. Please reload this page.

@refack

refack commented Nov 11, 2018

Copy link
Copy Markdown
Contributor Author

If you could test your changes locally before pushing, that would probably save us review cycles.

Sorry for the broken code, but I couldn't test this locally. IMHO we should cover this code in the test CI, since we have had some regressions, and maybe some more are hiding here ¯_(ツ)_/¯

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Nov 20, 2018

Copy link
Copy Markdown
Member

@refack Still working on this (or planning to in any event)? Making sure we shouldn't apply the stalled or blocked labels (or help wanted) or anything like that...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@refack
build,win: pack the install-tools scripts for dist
8a49733
@refack
refack force-pushed the distribute-windows-install-tools-script branch from f786fad to e815709 Compare November 25, 2018 00:44
@refack

refack commented Nov 25, 2018

Copy link
Copy Markdown
Contributor Author

Build test release - https://ci-release.nodejs.org/job/iojs+release/3961/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@refack refack added the wip Issues and PRs that are still a work in progress. label Nov 25, 2018
@refack
build,win: tweak source paths in product.wxs
0c802c5
@refack
refack force-pushed the distribute-windows-install-tools-script branch from e815709 to 0c802c5 Compare November 25, 2018 22:57
@refack refack removed the wip Issues and PRs that are still a work in progress. label Nov 25, 2018
@refack

refack commented Nov 25, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Tested manually and in https://ci-release.nodejs.org/job/iojs+release/3963/ ✔️
@joaocgreis PTAL

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

/ping @joaocgreis LGTY?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joaocgreis
joaocgreis approved these changes Dec 4, 2018
View reviewed changes

@joaocgreis joaocgreis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Trott

Trott commented Dec 5, 2018

Copy link
Copy Markdown
Member

Since this touches vcbuild.bat, a generic CI seems in order:
https://ci.nodejs.org/job/node-test-pull-request/19235/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 5, 2018
@Trott

Trott commented Dec 5, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19246/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Dec 6, 2018

Copy link
Copy Markdown
Member

Landed in 2fab5d5

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott Trott closed this Dec 6, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2018
@refack @Trott
build,win: pack the install-tools scripts for dist
2fab5d5
PR-URL: nodejs#24233
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 6, 2018
@refack @BridgeAR
build,win: pack the install-tools scripts for dist
66602ad
PR-URL: #24233
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 6, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current)
758cb07
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@refack @BridgeAR
build,win: pack the install-tools scripts for dist
706bc41
PR-URL: #24233
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>
BridgeAR pushed a commit that referenced this pull request Dec 7, 2018
@refack @BridgeAR
build,win: pack the install-tools scripts for dist
b80690d
PR-URL: #24233
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
2018-12-07, Version 11.4.0 (Current)
4f1297f
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
2018-12-07, Version 11.4.0 (Current)
bcef949
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
@refack
refack deleted the distribute-windows-install-tools-script branch December 21, 2018 01:12
refack added a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
build,win: pack the install-tools scripts for dist
87fdadd
PR-URL: nodejs#24233
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: João Reis <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
2018-12-07, Version 11.4.0 (Current)
5912f6d
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    nodejs#23708
  * The inspection `depth` default is now back at 2.
    nodejs#24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    nodejs#23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    nodejs#24739
* readline:
  * The `readline` module now supports async iterators.
    nodejs#23916
* repl:
  * The multiline history feature is removed.
    nodejs#24804
* tls:
  * Added min/max protocol version options.
    nodejs#24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. nodejs#24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    nodejs#23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    nodejs#24677
  * The install-tools scripts or now included in the dist.
    nodejs#24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    nodejs#24655

PR-URL: nodejs#24854
@refack
refack restored the distribute-windows-install-tools-script branch January 22, 2019 21:42
@BethGriggs BethGriggs added lts-watch-v10.x and removed lts-watch-v10.x labels Sep 3, 2019
@BethGriggs

BethGriggs commented Sep 3, 2019

Copy link
Copy Markdown
Member

Should this land on v10.x? Please open a backport PR if so

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@richardlau richardlau richardlau approved these changes
@bzoz bzoz Awaiting requested review from bzoz
+1 more reviewer
@joaocgreis joaocgreis joaocgreis approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. install Issues and PRs related to installing Node.js and its installers. semver-minor PRs that contain new features and should be released in the next minor version. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@refack @nodejs-github-bot @Trott @BethGriggs @joaocgreis @jasnell @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.