GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add antsmartian to collaborators by antsmartian · Pull Request #24655 · nodejs/node

Conversation

@antsmartian

@antsmartian antsmartian commented Nov 26, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Refs: #24340

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vsemozhetbyt reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2018

Copy link
Copy Markdown
Collaborator

@antsmartian sadly an error occured when I tried to trigger a build :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 26, 2018
thefourtheye
thefourtheye suggested changes Nov 26, 2018
View reviewed changes

@thefourtheye thefourtheye left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking till the CI infrastructure is available again. Ref: nodejs/build#1594

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@antsmartian
antsmartian force-pushed the add-to-docs branch 2 times, most recently from 9892087 to edacd78 Compare November 26, 2018 11:36
@antsmartian
doc: add antsmartian to collaborators
05f912f 
Fixes: nodejs#24340
@antsmartian
antsmartian force-pushed the add-to-docs branch from edacd78 to 05f912f Compare November 26, 2018 11:37
targos
targos approved these changes Nov 26, 2018
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Nov 26, 2018
View reviewed changes
richardlau
richardlau approved these changes Nov 26, 2018
View reviewed changes
@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 26, 2018
cjihrig
cjihrig approved these changes Nov 26, 2018
View reviewed changes
Leko
Leko approved these changes Nov 26, 2018
View reviewed changes
apapirovski
apapirovski approved these changes Nov 26, 2018
View reviewed changes
Trott
Trott approved these changes Nov 26, 2018
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vsemozhetbyt
vsemozhetbyt approved these changes Nov 26, 2018
View reviewed changes
starkwang
starkwang approved these changes Nov 27, 2018
View reviewed changes
@Trott

Trott commented Nov 28, 2018

Copy link
Copy Markdown
Member

Security release is out and the CI is available again. Hope this can finish soon! @antsmartian @thefourtheye
thefourtheye and antsmartian reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@antsmartian

antsmartian commented Nov 28, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1704/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
thefourtheye
thefourtheye approved these changes Nov 28, 2018
View reviewed changes
@antsmartian

antsmartian commented Nov 28, 2018

Copy link
Copy Markdown
Contributor Author

Landed in c3474f5
thefourtheye reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@antsmartian antsmartian closed this Nov 28, 2018
antsmartian added a commit that referenced this pull request Nov 28, 2018
@antsmartian
doc: add antsmartian to collaborators
c3474f5 
Fixes: #24340

PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@antsmartian

antsmartian commented Nov 28, 2018

Copy link
Copy Markdown
Contributor Author

Thanks everyone cc @thefourtheye 🎉
thefourtheye and gireeshpunathil reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thefourtheye thefourtheye mentioned this pull request Nov 28, 2018
Node.js Foundation Technical Steering Committee (TSC) Meeting 2018-11-28 nodejs/TSC#636
Closed
targos pushed a commit that referenced this pull request Nov 28, 2018
@antsmartian @targos
doc: add antsmartian to collaborators
3288c27 
Fixes: #24340

PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current), @BridgeAR
32ee780 
Notable Changes:

* util:
  The inspection `depth` default is now back at 2.
  #24326
* Added new collaborator:
  [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
  #24655
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current), @BridgeAR
b0273f1 
Notable Changes:

* util:
  The inspection `depth` default is now back at 2.
  #24326
* Added new collaborator:
  [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
  #24655
BridgeAR added a commit that referenced this pull request Dec 6, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current), @BridgeAR
2e6e799 
Notable Changes:

* util:
  The inspection `depth` default is now back at 2.
  #24326
* Added new collaborator:
  [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
  #24655

PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 6, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current)
758cb07 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
2018-12-07, Version 11.4.0 (Current)
4f1297f 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
2018-12-07, Version 11.4.0 (Current)
bcef949 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@antsmartian @refack
doc: add antsmartian to collaborators
df4071c 
Fixes: nodejs#24340

PR-URL: nodejs#24655
Refs: nodejs#24340
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
2018-12-07, Version 11.4.0 (Current)
5912f6d 
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    nodejs#23708
  * The inspection `depth` default is now back at 2.
    nodejs#24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    nodejs#23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    nodejs#24739
* readline:
  * The `readline` module now supports async iterators.
    nodejs#23916
* repl:
  * The multiline history feature is removed.
    nodejs#24804
* tls:
  * Added min/max protocol version options.
    nodejs#24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. nodejs#24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    nodejs#23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    nodejs#24677
  * The install-tools scripts or now included in the dist.
    nodejs#24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    nodejs#24655

PR-URL: nodejs#24854
@antsmartian
antsmartian deleted the add-to-docs branch January 29, 2019 16:33
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@antsmartian @BethGriggs
doc: add antsmartian to collaborators
3e4b93a 
Fixes: #24340

PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
@BethGriggs BethGriggs added the land-on-v10.x label Feb 12, 2019
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@antsmartian @rvagg
doc: add antsmartian to collaborators
24701de 
Fixes: #24340

PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
BethGriggs added a commit that referenced this pull request Mar 4, 2019
@BethGriggs
2019-03-05, Version 10.15.3 'Dubnium' (LTS)
1a96d83 
Notable Changes

* **doc**
  * add antsmartian to collaborators (Anto Aravinth)
    [#24655](#24655)
* **http**
  * fix error check in Execute() (Brian White)
    [#25863](#25863)
* **stream**
  * fix end-of-stream for HTTP/2 (Anna Henningsen)
    [#24926](#24926)

PR-URL: #26063
BethGriggs added a commit that referenced this pull request Mar 5, 2019
@BethGriggs
2019-03-05, Version 10.15.3 'Dubnium' (LTS)
a52c1ea 
Notable Changes

* **doc**
  * add antsmartian to collaborators (Anto Aravinth)
    [#24655](#24655)
* **http**
  * fix error check in Execute() (Brian White)
    [#25863](#25863)
* **stream**
  * fix end-of-stream for HTTP/2 (Anna Henningsen)
    [#24926](#24926)

PR-URL: #26063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
+6 more reviewers
@apapirovski apapirovski apapirovski approved these changes
@thefourtheye thefourtheye thefourtheye approved these changes
@Leko Leko Leko approved these changes
@targos targos targos approved these changes
@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes
@starkwang starkwang starkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

13 participants

@antsmartian @nodejs-github-bot @Trott @apapirovski @thefourtheye @Leko @targos @cjihrig @richardlau @gireeshpunathil @vsemozhetbyt @starkwang @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.