GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — Revert "util: change util.inspect depth default" by devsnek · Pull Request #24326 · nodejs/node Conversation
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I was not aware that #23350 never landed. Shall we go for that instead or shall we revert everything fully first? I am fine either way as I intend to do a breadth wide inspection instead of the current inspection which allows to check for the actual lines being printed and therefore have a reasonable way to limit the output. The implementation is just not that trivial. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@BridgeAR I'd prefer it go all the way back to 2, and then we can work our way up if that is deemed the best direction. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in 7082c61 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This reverts commit ac7450a. This fully reverts the changes to util.inspect depth. It has caused breakage in logging to existing apps, and even something as simple as `console.log(require)` will cause >1m freezes. I've heard nothing but negative feedback (seriously not a single person has expressed anything positive about this change) and personally i find this change extremely annoying. PR-URL: nodejs#24326 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: John-David Dalton <[email protected]>
|
It would have been good to include the other commit from the original PR as well. Otherwise the default depth for the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@BridgeAR I left that commit out on purpose, as it wasn't breaking anything and seems reasonable to not override anything. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@BridgeAR then revert it i guess? regardless of that, this revert was approved and merged and should be in a release |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It was my intention to release it but it broke tests without the other commit backported as well. That's why I pulled it out again as I did not want to block the release. So there is no disagreement here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
What's the next step here? Open a backport PR for v11.x that includes a revert of the other commit? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
i'm not really sure. apparently some tests are failing on 11.x that aren't failing on master 🤷♂️ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Notable Changes: * util: The inspection `depth` default is now back at 2. #24326 * Added new collaborator: [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655
Notable Changes: * util: The inspection `depth` default is now back at 2. #24326 * Added new collaborator: [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655
Notable Changes: * util: The inspection `depth` default is now back at 2. #24326 * Added new collaborator: [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655 PR-URL: #24854
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
|
Did anyone actually checked the claim that |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
nodejs#23708
* The inspection `depth` default is now back at 2.
nodejs#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
nodejs#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
nodejs#24739
* readline:
* The `readline` module now supports async iterators.
nodejs#23916
* repl:
* The multiline history feature is removed.
nodejs#24804
* tls:
* Added min/max protocol version options.
nodejs#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. nodejs#24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
nodejs#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
nodejs#24677
* The install-tools scripts or now included in the dist.
nodejs#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
nodejs#24655
PR-URL: nodejs#24854
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.