GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — repl: revert multiline history by BridgeAR · Pull Request #24804 · nodejs/node

Conversation

@BridgeAR

@BridgeAR BridgeAR commented Dec 3, 2018

Copy link
Copy Markdown
Member

So far the multiline history caused a lot of problems and the current logic is not suitable at all as such. It changes the actual content of the history and should not be used at all.

I struggle a lot with my history at the moment as it often forgets entries and similar and until a proper solution is found this should be reverted.

We discussed some possibilities how to properly implement this feature in #24231.

Refs: #24231

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@BridgeAR
BridgeAR requested a review from antsmartian December 3, 2018 13:47
@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2018

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1801/pipeline

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem. labels Dec 3, 2018
@BridgeAR BridgeAR changed the title Revert multiline history repl: revert multiline history Dec 3, 2018
@antsmartian

antsmartian commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

@BridgeAR Agree with you. We can revisit this idea with the ideas suggested on the issue tracker.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

antsmartian
antsmartian approved these changes Dec 3, 2018
View reviewed changes
@antsmartian

antsmartian commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/19150/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@BridgeAR
BridgeAR requested a review from targos December 3, 2018 17:09
targos
targos approved these changes Dec 3, 2018
View reviewed changes
@addaleax

addaleax commented Dec 3, 2018

Copy link
Copy Markdown
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19158/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Fishrock123
Fishrock123 approved these changes Dec 3, 2018
View reviewed changes
@BridgeAR BridgeAR added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 3, 2018
@targos targos mentioned this pull request Dec 4, 2018
repl history broke since 11.2.0 #24821
Closed
@BridgeAR BridgeAR added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Dec 4, 2018
@BridgeAR

BridgeAR commented Dec 4, 2018

Copy link
Copy Markdown
Member Author

Please +1 to fast track this.

antsmartian and addaleax reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@addaleax

addaleax commented Dec 4, 2018

Copy link
Copy Markdown
Member

This doesn’t really seem suitable for fast-tracking? Is there a specific reason for doing so?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@BridgeAR

BridgeAR commented Dec 4, 2018

Copy link
Copy Markdown
Member Author

@addaleax I want to prepare the next 11.x release and I would like to include this PR in that release. Since the feature is clearly broken (there were multiple bug reports about it), I don't see why this should not be suitable?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@addaleax

addaleax commented Dec 4, 2018

Copy link
Copy Markdown
Member

@BridgeAR I trust you to make that call if you are sure about it, but generally, removing methods from a class that is public API is not exactly what we usually fast-track? If this is really broken, then yeah, I guess you can go ahead 👍

BridgeAR reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung joyeecheung mentioned this pull request Dec 5, 2018
CI failures: 20181201-20181205 nodejs/reliability#19
Closed
@addaleax

addaleax commented Dec 5, 2018

Copy link
Copy Markdown
Member

@BridgeAR Looks like this needs a rebase?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@addaleax addaleax removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 5, 2018
BridgeAR added 2 commits December 5, 2018 18:24
@BridgeAR
Revert "repl: handle buffered string logic on finish"
ced4324
This reverts commit eb42c1e.
@BridgeAR
Revert "lib: repl multiline history support"
1a33e14
This reverts commit dd7a3d2.
@BridgeAR
BridgeAR force-pushed the fix-multiline-history branch from 746b235 to 1a33e14 Compare December 5, 2018 17:25
@BridgeAR

BridgeAR commented Dec 5, 2018

Copy link
Copy Markdown
Member Author

Rebased

CI https://ci.nodejs.org/job/node-test-pull-request/19232/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danbev

danbev commented Dec 6, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Re-run of failing node-test-commit-windows-fanned ✔️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Dec 6, 2018

Copy link
Copy Markdown
Member

Landed in aa943d0...b1ada6c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott Trott closed this Dec 6, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2018
@BridgeAR @Trott
Revert "repl: handle buffered string logic on finish"
fd2467a
This reverts commit eb42c1e.

PR-URL: nodejs#24804
Refs: nodejs#24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2018
@BridgeAR @Trott
Revert "lib: repl multiline history support"
b1ada6c
This reverts commit dd7a3d2.

PR-URL: nodejs#24804
Refs: nodejs#24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 6, 2018
@BridgeAR
Revert "repl: handle buffered string logic on finish"
858b23a
This reverts commit eb42c1e.

PR-URL: #24804
Refs: #24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 6, 2018
@BridgeAR
Revert "lib: repl multiline history support"
3c98cf1
This reverts commit dd7a3d2.

PR-URL: #24804
Refs: #24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 6, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current)
758cb07
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
@BridgeAR BridgeAR mentioned this pull request Dec 6, 2018
v11.4.0 proposal #24854
Merged
4 tasks done
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
Revert "repl: handle buffered string logic on finish"
6fed6f5
This reverts commit eb42c1e.

PR-URL: #24804
Refs: #24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
Revert "lib: repl multiline history support"
73bc5fd
This reverts commit dd7a3d2.

PR-URL: #24804
Refs: #24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
Revert "repl: handle buffered string logic on finish"
adae559
This reverts commit eb42c1e.

PR-URL: #24804
Refs: #24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
Revert "lib: repl multiline history support"
f1bcf90
This reverts commit dd7a3d2.

PR-URL: #24804
Refs: #24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
2018-12-07, Version 11.4.0 (Current)
4f1297f
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
2018-12-07, Version 11.4.0 (Current)
bcef949
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    #23708
  * The inspection `depth` default is now back at 2.
    #24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    #23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    #24739
* readline:
  * The `readline` module now supports async iterators.
    #23916
* repl:
  * The multiline history feature is removed.
    #24804
* tls:
  * Added min/max protocol version options.
    #24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. #24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    #23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    #24677
  * The install-tools scripts or now included in the dist.
    #24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    #24655

PR-URL: #24854
This was referenced Dec 7, 2018
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#261
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#262
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#263
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#264
Closed
2018-12-07 Version 11.4.0 (Current) @BridgeAR beevelop/docker-android-nodejs#265
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
Revert "repl: handle buffered string logic on finish"
1e656f5
This reverts commit eb42c1e.

PR-URL: nodejs#24804
Refs: nodejs#24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
Revert "lib: repl multiline history support"
f1af194
This reverts commit dd7a3d2.

PR-URL: nodejs#24804
Refs: nodejs#24231
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR @refack
2018-12-07, Version 11.4.0 (Current)
5912f6d
Notable Changes:

* console,util:
  * `console` functions now handle symbols as defined in the spec.
    nodejs#23708
  * The inspection `depth` default is now back at 2.
    nodejs#24326
* dgram,net:
  * Added ipv6Only option for `net` and `dgram`.
    nodejs#23798
* http:
  * Chosing between the http parser is now possible per runtime flag.
    nodejs#24739
* readline:
  * The `readline` module now supports async iterators.
    nodejs#23916
* repl:
  * The multiline history feature is removed.
    nodejs#24804
* tls:
  * Added min/max protocol version options.
    nodejs#24405
  * The X.509 public key info now includes the RSA bit size and the
    elliptic curve. nodejs#24358
* url:
  * `pathToFileURL()` now supports LF, CR and TAB.
    nodejs#23720
* Windows:
  * Tools are not installed using Boxstarter anymore.
    nodejs#24677
  * The install-tools scripts or now included in the dist.
    nodejs#24233
* Added new collaborator:
  * [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
    nodejs#24655

PR-URL: nodejs#24854
@aleclarson aleclarson mentioned this pull request Jan 21, 2019
feat: command history TypeStrong/ts-node#757
Closed
@BethGriggs BethGriggs added dont-land-on-v10.x and removed dont-land-on-v10.x labels Jul 3, 2019
@BridgeAR
BridgeAR deleted the fix-multiline-history branch January 20, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@Fishrock123 Fishrock123 Fishrock123 approved these changes
@antsmartian antsmartian antsmartian approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@BridgeAR @nodejs-github-bot @antsmartian @addaleax @danbev @Trott @Fishrock123 @targos @BethGriggs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.