GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: adjust typecheck for `type` in `fs.symlink()` by LiviaMedeiros · Pull Request #49741 · nodejs/node

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Sep 20, 2023

Copy link
Copy Markdown
Member

Alternative to: #44641

  • Throws TypeError instead of Error
  • Enables autodetection on Windows if type === undefined (as intended in win, fs: detect if symlink target is a directory #23724)
  • Explicitly disallows unknown strings and non-string values

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and larson-carter reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originating in Node.js core. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Sep 20, 2023
@LiviaMedeiros LiviaMedeiros added semver-major PRs that contain breaking changes and should be released in the next major version. needs-citgm PRs that need a CITGM CI run. labels Sep 20, 2023
aduh95
aduh95 reviewed Sep 20, 2023
View reviewed changes
Comment thread lib/internal/errors.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 21, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 approved these changes Sep 21, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023 •
edited by LiviaMedeiros
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54124/

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3258/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 22, 2023
CI Reliability 2023-09-22 nodejs/reliability#673
Open
17 tasks
lpinca
lpinca approved these changes Sep 22, 2023
View reviewed changes
This was referenced Sep 23, 2023
CI Reliability 2023-09-23 nodejs/reliability#674
Open
CI Reliability 2023-09-24 nodejs/reliability#675
Open
@aduh95

aduh95 commented Sep 24, 2023

Copy link
Copy Markdown
Contributor

Ping @nodejs/TSC for reviews since this is semver-major.
Aside: The CITGM is quite hard to decipher, hopefully nodejs/citgm#959 will fix that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3282/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54369/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig reviewed Sep 29, 2023
View reviewed changes
Comment thread lib/fs.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Oct 9, 2023
View reviewed changes
Mifrill
Mifrill reviewed Oct 17, 2023
View reviewed changes
Comment thread lib/internal/fs/utils.js Outdated
Comment on lines 625 to 657

@Mifrill Mifrill Oct 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
switch (type) {
case undefined:
case null:
case 'file':
return 0;
case 'dir':
return UV_FS_SYMLINK_DIR;
case 'junction':
return UV_FS_SYMLINK_JUNCTION;
const linkTypes = {
undefined: 0,
null: 0,
file: 0,
dir: UV_FS_SYMLINK_DIR,
junction: UV_FS_SYMLINK_JUNCTION
};
return linkTypes[type] || 0;

The || 0 is a fallback in case the type is not found in the linkTypes object. If type is not one of the defined values in the linkTypes object, linkType will default to 0. This ensures that linkType always has a value and doesn't become undefined. It's a way to handle unexpected or unknown values for type.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@LiviaMedeiros LiviaMedeiros Nov 18, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intentionally don't fallback to file. If an unknown type is passed, we must throw TypeError, which is done by validateOneOf().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mcollina
mcollina approved these changes Nov 18, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@LiviaMedeiros LiviaMedeiros added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 18, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55735/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Nov 19, 2023
View reviewed changes
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 26, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 26, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
LiviaMedeiros added 2 commits May 6, 2024 14:16
@LiviaMedeiros
fs: adjust typecheck for type in fs.symlink()
840e418 
Throws `TypeError` instead of `Error`
Enables autodetection on Windows if `type === undefined`
Explicitly disallows unknown strings and non-string values
@LiviaMedeiros
squash: move ERR_FS_INVALID_SYMLINK_TYPE to removed section
5396244
@LiviaMedeiros
LiviaMedeiros force-pushed the fs-forbit-symlink-nonstring branch from 53e1933 to 5396244 Compare May 6, 2024 06:17
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 6, 2024
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 6, 2024
@github-actions

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8964951019
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 6, 2024 •
edited by LiviaMedeiros
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58976/

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3429/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LiviaMedeiros LiviaMedeiros removed the request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. label May 6, 2024
@nodejs-github-bot

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58981/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes May 6, 2024
View reviewed changes
@mcollina mcollina added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 6, 2024
@nodejs-github-bot
nodejs-github-bot merged commit f202322 into nodejs:main May 6, 2024
@nodejs-github-bot

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in f202322
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@LiviaMedeiros @soophoo
fs: adjust typecheck for type in fs.symlink()
0a07001 
Throws `TypeError` instead of `Error`
Enables autodetection on Windows if `type === undefined`
Explicitly disallows unknown strings and non-string values

PR-URL: nodejs#49741
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
RafaelGSS added a commit that referenced this pull request Oct 9, 2024
@RafaelGSS
2024-10-15, Version 23.0.0 (Current)
1c258f4 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 11, 2024
@RafaelGSS
2024-10-15, Version 23.0.0 (Current)
2ba706f 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 16, 2024
@RafaelGSS
2024-10-16, Version 23.0.0 (Current)
80c8998 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 16, 2024
@RafaelGSS
2024-10-16, Version 23.0.0 (Current)
fa8f149 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig left review comments
@aduh95 aduh95 aduh95 approved these changes
@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+2 more reviewers
@Mifrill Mifrill Mifrill left review comments
@larson-carter larson-carter larson-carter approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. errors Issues and PRs related to JavaScript errors originating in Node.js core. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@LiviaMedeiros @nodejs-github-bot @aduh95 @targos @mcollina @jasnell @lpinca @anonrig @gireeshpunathil @larson-carter @Mifrill @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.