GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — events: set EventEmitterAsyncResource fields private by anonrig · Pull Request #54889 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Sep 11, 2024

Copy link
Copy Markdown
Member

This is a semver-major because it changes the error messages.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, avivkeller, gurgunday, tonivj5, and pluris reacted with thumbs up emoji
All reactions
  • 👍 5 reactions
@anonrig anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 11, 2024
@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to EventEmitter and the events module. needs-ci PRs that need a full CI run. labels Sep 11, 2024
@anonrig
anonrig force-pushed the events-eventemitterasyncresource branch from 5f8d924 to fc3ffe2 Compare September 11, 2024 15:46
@codecov

codecov Bot commented Sep 11, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (9db6327) to head (bd33b0b).
Report is 47 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54889      +/-   ##
==========================================
- Coverage   88.05%   88.05%   -0.01%     
==========================================
  Files         651      651              
  Lines      183405   183393      -12     
  Branches    35822    35820       -2     
==========================================
- Hits       161499   161486      -13     
- Misses      15159    15162       +3     
+ Partials     6747     6745       -2
Files with missing lines Coverage Δ
lib/events.js 98.43% <100.00%> (+0.06%) ⬆️

... and 27 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Sep 12, 2024
View reviewed changes
@anonrig
events: set EventEmitterAsyncResource fields private
bd33b0b
@anonrig
anonrig force-pushed the events-eventemitterasyncresource branch from fc3ffe2 to bd33b0b Compare September 12, 2024 15:28
@anonrig

anonrig commented Sep 12, 2024

Copy link
Copy Markdown
Member Author

cc @nodejs/tsc this requires 2 TSC member approval. can you take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Sep 12, 2024

Copy link
Copy Markdown
Member

I can give my +1 for the semver-major requirement, but it's not my area of expertise to review the actual changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig requested review from mcollina and ronag September 14, 2024 23:42
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62440/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Sep 15, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
benjamingr
benjamingr approved these changes Sep 15, 2024
View reviewed changes
@benjamingr

benjamingr commented Sep 15, 2024

Copy link
Copy Markdown
Member

I'm honestly fine with landing as semver-minor since I don't believe there is breakage potential here (someone would literally need to write code trying to use it with an incorrect this and relying on the failure).

Also happy birthday!
anonrig reacted with heart emoji tonivj5 reacted with eyes emoji
All reactions
  • ❤️ 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62461/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62488/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 17, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d5c29ba into nodejs:main Sep 17, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 17, 2024

Copy link
Copy Markdown
Collaborator

Landed in d5c29ba
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2024
2024-10-16, Version 23.0.0 (Current) #55338
Merged
RafaelGSS added a commit that referenced this pull request Oct 9, 2024
@RafaelGSS
2024-10-15, Version 23.0.0 (Current)
1c258f4 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 11, 2024
@RafaelGSS
2024-10-15, Version 23.0.0 (Current)
2ba706f 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 16, 2024
@RafaelGSS
2024-10-16, Version 23.0.0 (Current)
80c8998 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
RafaelGSS added a commit that referenced this pull request Oct 16, 2024
@RafaelGSS
2024-10-16, Version 23.0.0 (Current)
fa8f149 
Semver-Major Commits:

assert,util:
  * (SEMVER-MAJOR) change WeakMap and WeakSet comparison handling (Cristian Barlutiu) #53495
buffer:
  * (SEMVER-MAJOR) throw when writing beyond buffer" (Robert Nagy) #54588
  * (SEMVER-MAJOR) make File cloneable (Matthew Aitken) #47613
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable ICF for mksnapshot (Leszek Swirski) #54077
  * (SEMVER-MAJOR) include v8-sandbox.h header in distribution (Michaël Zasso) #54077
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #54077
  * (SEMVER-MAJOR) warn for GCC versions earlier than 12.2 (Michaël Zasso) #54081
  * (SEMVER-MAJOR) drop experimental support for Windows <10 (Michaël Zasso) #54079
  * (SEMVER-MAJOR) remove support for 32-bit Windows (Michaël Zasso) #53184
  * (SEMVER-MAJOR) compile with C++20 support (Michaël Zasso) #45427
child_process:
  * (SEMVER-MAJOR) remove unused internal event (Rich Trott) #53793
cli:
  * (SEMVER-MAJOR) remove deprecated V8 flag (Omer Katz) #54761
  * (SEMVER-MAJOR) move --trace-atomics-wait to eol (Marco Ippolito) #52747
  * (SEMVER-MAJOR) remove --no-experimental-global-customevent flag (Daeyeon Jeong) #52723
  * (SEMVER-MAJOR) remove --no-experimental-fetch flag (Filip Skokan) #52611
  * (SEMVER-MAJOR) remove --no-experimental-global-webcrypto flag (Filip Skokan) #52564
crypto:
  * (SEMVER-MAJOR) runtime deprecate crypto.fips (Yagiz Nizipli) #55019
  * (SEMVER-MAJOR) remove ERR_CRYPTO_SCRYPT_INVALID_PARAMETER (Tobias Nießen) #53305
  * (SEMVER-MAJOR) move DEP0182 to runtime deprecation (Tobias Nießen) #52552
deps:
  * (SEMVER-MAJOR) V8: cherry-pick 97199f686e2f (Michaël Zasso) #54536
  * (SEMVER-MAJOR) V8: cherry-pick 01a47f3ffff2 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) patch V8 to support older Clang versions (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54536
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54536
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54536
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54536
  * (SEMVER-MAJOR) update V8 to 12.9.202.18 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) remove bogus V8 DCHECK (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 00e9eeb3fb2c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick b1397772c70c (Michaël Zasso) #54077
  * (SEMVER-MAJOR) V8: cherry-pick 35888fee7bba (Joyee Cheung) #54077
  * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #54077
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #54077
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #54077
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #54077
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #54077
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 12.8.374.13 (Michaël Zasso) #54077
doc:
  * (SEMVER-MAJOR) reflect toolchains used for official binaries (Richard Lau) #54967
  * (SEMVER-MAJOR) use gcc 12 on AIX for Node.js >=23 (Richard Lau) #54338
esm:
  * (SEMVER-MAJOR) export 'module.exports' on ESM CJS wrapper (Guy Bedford) #53848
events:
  * (SEMVER-MAJOR) set EventEmitterAsyncResource fields private (Yagiz Nizipli) #54889
fs:
  * (SEMVER-MAJOR) adjust typecheck for `type` in `fs.symlink()` (Livia Medeiros) #49741
  * (SEMVER-MAJOR) runtime deprecate `dirent.path` (Antoine du Hamel) #51050
lib:
  * (SEMVER-MAJOR) validate signals with interface converter (Jason Zhang) #54965
  * (SEMVER-MAJOR) implement interface converter in webidl (Jason Zhang) #54965
  * (SEMVER-MAJOR) expose global CloseEvent (Matthew Aitken) #53355
net:
  * (SEMVER-MAJOR) validate host name for server listen (Jason Zhang) #54470
path:
  * (SEMVER-MAJOR) fix bugs and inconsistencies (Hüseyin Açacak) #54224
process:
  * (SEMVER-MAJOR) remove `process.assert` (Aviv Keller) #55035
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 131 (Michaël Zasso) #54536
  * (SEMVER-MAJOR) stop using deprecated fields of `v8::FastApiCallbackOptions` (Andreas Haas) #54077
  * (SEMVER-MAJOR) remove dependency on wrapper-descriptor-based CppHeap (Joyee Cheung) #54077
  * (SEMVER-MAJOR) add source location to v8::TaskRunner (François Doray) #54077
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 129 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) do not use soon-to-be-deprecated V8 API (Igor Sheludko) #53174
  * (SEMVER-MAJOR) add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc (theanarkh) #52347
stream:
  * (SEMVER-MAJOR) pipe to a closed or destroyed stream is not allowed in pipeline (jakecastelli) #53241
string_decoder:
  * (SEMVER-MAJOR) refactor encoding validation (Yagiz Nizipli) #54957
test:
  * (SEMVER-MAJOR) update v8-stats test for V8 12.6 (Michaël Zasso) #54077
test_runner:
  * (SEMVER-MAJOR) detect only tests when --test is not used (Colin Ihrig) #54881
  * (SEMVER-MAJOR) always make spec the default reporter (Colin Ihrig) #54548
  * (SEMVER-MAJOR) expose lcov reporter as newable function (Chemi Atlow) #52403
timers:
  * (SEMVER-MAJOR) emit warning if delay is negative or NaN (jakecastelli) #46678
tls:
  * (SEMVER-MAJOR) fix 'ERR_TLS_PSK_SET_IDENTIY_HINT_FAILED' typo (Aviv Keller) #52627
tools:
  * (SEMVER-MAJOR) add additonal include dirs for V8 on AIX (Abdirahim Musse) #54536
  * (SEMVER-MAJOR) update V8 gypfiles for 12.8 (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.7 (Richard Lau) #54077
  * (SEMVER-MAJOR) update V8 gypfiles for 12.6 (Michaël Zasso) #54077
util:
  * (SEMVER-MAJOR) move util.log to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isPrimitive to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isFunction to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isError to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isDate to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isObject to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isRegExp to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isSymbol to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isString to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNumber to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNullOrUndefined to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isNull to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBuffer to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util.isBoolean to eol (marco-ippolito) #52744
  * (SEMVER-MAJOR) move util._extend to eol (marco-ippolito) #52744
zlib:
  * (SEMVER-MAJOR) remove `zlib.bytesRead` (Yagiz Nizipli) #55020

PR-URL: #55338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@ronag ronag Awaiting requested review from ronag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

events Issues and PRs related to EventEmitter and the events module. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@anonrig @targos @nodejs-github-bot @benjamingr @mcollina @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.