GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-102011: use sys.exception() instead of sys.exc_info() in docs where possible by iritkatriel · Pull Request #102012 · python/cpython

Conversation

iritkatriel commented Feb 18, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Some of the docs no longer need to mention sys.exc_info() #102011

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-102011: use sys.exception() instead of sys.exc_info() in doc…

93a9554

…s where possible

bedevere-bot added the awaiting core review label

Feb 18, 2023

bedevere-bot mentioned this pull request

Feb 18, 2023

Some of the docs no longer need to mention sys.exc_info() #102011

Closed

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

Feb 18, 2023

iritkatriel requested review from CAM-Gerlach and erlend-aasland

February 20, 2023 10:13

erlend-aasland reviewed

Feb 20, 2023

View reviewed changes

Comment thread

Doc/library/traceback.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel and others added 2 commits

February 20, 2023 10:31


          returned by

fae1e49

Co-authored-by: Erlend E. Aasland <[email protected]>


          Merge branch 'main' into exc_info_doc

57752ef

TeamSpen210 reviewed

Feb 20, 2023

View reviewed changes

Comment thread

Doc/library/traceback.rst Outdated

		The module uses traceback objects --- this is the object type that is stored in
		the :data:`sys.last_traceback` variable and returned as the third item from
		:func:`sys.exc_info`.
		the :data:`sys.last_traceback` variable and returned by :func:`sys.exception`.

TeamSpen210 Feb 20, 2023

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is missing .__traceback__?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel and erlend-aasland reacted with thumbs up emoji

All reactions

👍 2 reactions


          fix definition of traceback type

4078acc

erlend-aasland approved these changes

Feb 20, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Feb 20, 2023

iritkatriel merged commit 4d3bc89 into python:main

Feb 20, 2023

bedevere-bot removed the awaiting merge label

Feb 20, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Feb 20, 2023


          Merge branch 'main' into inlinecomp2

9f0fc5b

* main: (60 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...

CAM-Gerlach commented Feb 21, 2023

Copy link

Copy Markdown

Member

Should we backport this to 3.11, since sys.exception was introduced in that version? Or is there a reason this needs to stay 3.12 only?

iritkatriel reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland commented Feb 21, 2023

Copy link

Copy Markdown

Contributor

SGTM, @CAM-Gerlach

iritkatriel reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added the needs backport to 3.11 only security fixes label

Feb 21, 2023

miss-islington commented Feb 21, 2023

Copy link

Copy Markdown

Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 21, 2023


          pythongh-102011: use sys.exception() instead of sys.exc_info() in doc…

69f5000

…s where possible (pythonGH-102012)

(cherry picked from commit 4d3bc89)

Co-authored-by: Irit Katriel <[email protected]>

bedevere-bot commented Feb 21, 2023

Copy link

Copy Markdown

GH-102101 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Feb 21, 2023

miss-islington added a commit that referenced this pull request

Feb 21, 2023


          gh-102011: use sys.exception() instead of sys.exc_info() in docs wher…

78eee76

…e possible (GH-102012)

(cherry picked from commit 4d3bc89)

Co-authored-by: Irit Katriel <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Feb 22, 2023


          Merge branch 'main' into inlinecomp

544b30c

* main: (225 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...

carljm added a commit to carljm/cpython that referenced this pull request

Feb 23, 2023


          Merge branch 'main' into lockfreecp

b257a16

* main: (76 commits)
  Fix syntax error in struct doc example (python#102160)
  pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)
  pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)
  Few coverage nitpicks for the cmath module (python#102067)
  pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)
  pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)
  pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)
  pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
  pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)
  pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)
  pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
  pythongh-100556: Improve clarity of `or` docs (python#100589)
  pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)
  pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)
  pythongh-101578: Amend exception docs (python#102057)
  pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  ...

iritkatriel deleted the exc_info_doc branch

April 3, 2023 17:45

python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request

Sep 1, 2024


          pythongh-102011: use sys.exception() instead of sys.exc_info() in doc…

43b4094

…s where possible (python#102012)

python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request

Sep 1, 2024


          pythongh-102011: use sys.exception() instead of sys.exc_info() in doc…

7852ee7

…s where possible (python#102012)

Reviewers

erlend-aasland

erlend-aasland approved these changes

CAM-Gerlach

Awaiting requested review from CAM-Gerlach

+1 more reviewer

TeamSpen210

TeamSpen210 left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

iritkatriel commented Feb 18, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TeamSpen210 Feb 20, 2023

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach commented Feb 21, 2023

Uh oh!

erlend-aasland commented Feb 21, 2023

Uh oh!

miss-islington commented Feb 21, 2023

Uh oh!

bedevere-bot commented Feb 21, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iritkatriel commented Feb 18, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.