GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove or update bitbucket links by sblondon · Pull Request #101963 · python/cpython

Conversation

@sblondon

@sblondon sblondon commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

Since Mercurial removal from bitbucket.org, some links are broken.
In this PR, they are replaced by github.com or webarchive links if available. Otherwise, they are removed.

I don't think news are needed (no blurb).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@sblondon
sblondon requested review from a team, barneygale and vsajip as code owners February 16, 2023 21:45
@bedevere-bot bedevere-bot added the awaiting review label Feb 16, 2023
zware
zware reviewed Feb 16, 2023
View reviewed changes
Comment thread Doc/library/venv.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_pathlib.py
@os_helper.skip_unless_symlink
def test_resolve_dot(self):
# See https://bitbucket.org/pitrou/pathlib/issue/9/pathresolve-fails-on-complex-symlinks
# See http://web.archive.org/web/20200623062557/https://bitbucket.org/pitrou/pathlib/issues/9/

@zware zware Feb 16, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this comment really adds much; better to just remove it than use an archive link.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sblondon sblondon Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link was added in the same commit than the unit test so, at least when introduced, it meant something. I don't have a strong opinion about this link but I think it would be better to keep it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zware zware Feb 17, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiy-storchaka, @pitrou Do either of you remember enough context to suggest a replacement for this comment?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pitrou pitrou Feb 17, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the link shows in which context the test was introduced in the first place. It doesn't hurt to keep it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware zware added skip issue skip news labels Feb 16, 2023
sblondon and others added 2 commits February 17, 2023 11:35
@sblondon
Remove or update bitbucket links
d9d90e4 
Since Mercurial removal from bitbucket.org, some links are broken.
They are replaced by github.com or webarchive.org links if available. Otherwise, they are removed.
@hauntsaninja
Merge branch 'main' into bitbucket-broken-link
bf741f5
JulienPalard
JulienPalard approved these changes Mar 8, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 8, 2023
@JulienPalard
JulienPalard merged commit 7d801f2 into python:main Mar 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 8, 2023
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
@sblondon
sblondon deleted the bitbucket-broken-link branch March 9, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments
@zware zware zware left review comments
@JulienPalard JulienPalard JulienPalard approved these changes
@barneygale barneygale Awaiting requested review from barneygale
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sblondon @JulienPalard @pitrou @zware @bedevere-bot @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.