GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules by sobolevn · Pull Request #102526 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've decided to unite these simple fixes into a single PR.

Warnings:

./cpython/Doc/library/zipapp.rst:218: WARNING: py:class reference target not found: BytesIO
./cpython/Doc/library/zipfile.rst:287: WARNING: py:meth reference target not found: __iter__

Some details:

  1. Fixed missing link to https://docs.python.org/3/library/io.html#io.BytesIO
  2. Fixed missing link to https://docs.python.org/3/library/stdtypes.html#container.__iter__
  • Issue: Fix all Sphinx reference warnings in the documentation #101100

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-101100: Fix sphinx warnings in zipapp and zipfile modules
b37afb7
@sobolevn
sobolevn requested a review from hugovk March 8, 2023 07:50
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 8, 2023
Fix all Sphinx reference warnings in the documentation #101100
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 8, 2023
AlexWaygood
AlexWaygood approved these changes Mar 8, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 8, 2023
@AlexWaygood
AlexWaygood merged commit 1f557f9 into python:main Mar 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 8, 2023
@AlexWaygood AlexWaygood added needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 8, 2023
@miss-islington

miss-islington commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2023
@sobolevn @miss-islington
pythongh-101100: Fix sphinx warnings in zipapp and zipfile modules (
97afd37 
pythonGH-102526)

(cherry picked from commit 1f557f9)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Mar 8, 2023

Copy link
Copy Markdown

GH-102529 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2023
@sobolevn @miss-islington
pythongh-101100: Fix sphinx warnings in zipapp and zipfile modules (
3046f48 
pythonGH-102526)

(cherry picked from commit 1f557f9)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 8, 2023
@bedevere-bot

bedevere-bot commented Mar 8, 2023

Copy link
Copy Markdown

GH-102530 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 8, 2023
miss-islington added a commit that referenced this pull request Mar 8, 2023
@miss-islington @sobolevn
gh-101100: Fix sphinx warnings in zipapp and zipfile modules (GH-…
ffb41ea 
…102526)

(cherry picked from commit 1f557f9)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Mar 8, 2023
@miss-islington @sobolevn
gh-101100: Fix sphinx warnings in zipapp and zipfile modules (GH-…
7276ee0 
…102526)

(cherry picked from commit 1f557f9)

Co-authored-by: Nikita Sobolev <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.