GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix typo in async generator code field name `ag_code` by kumaraditya303 · Pull Request #102448 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Mar 5, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
fix typo
b668f75
@kumaraditya303
kumaraditya303 requested a review from markshannon as a code owner March 5, 2023 17:32
@bedevere-bot bedevere-bot added the awaiting core review label Mar 5, 2023
@kumaraditya303
kumaraditya303 requested a review from AlexWaygood March 5, 2023 17:32
@kumaraditya303 kumaraditya303 added skip issue skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 5, 2023
@AlexWaygood

AlexWaygood commented Mar 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Not too familiar with this code and not very confident with C, so I'll leave this one to you and Mark :)

(The change looks correct, but it's weird to me that this wasn't flagged by our tests -- worth a test, maybe? But as I say, I'm probably not the right reviewer here :)
kumaraditya303 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood removed their request for review March 5, 2023 17:55
@kumaraditya303

kumaraditya303 commented Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

Not too familiar with this code and not very confident with C, so I'll leave this one to you and Mark :)

I didn't mean to request review, might have mis-clicked while applying labels or got distracted and didn't see. Sorry.
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 merged commit e499680 into python:main Mar 8, 2023
@miss-islington

miss-islington commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 8, 2023
@kumaraditya303
kumaraditya303 deleted the typo branch March 8, 2023 03:39
@miss-islington

miss-islington commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Sorry, @kumaraditya303, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e499680100a9d4fa4b673cbcfebc32212b4f848a 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned kumaraditya303 Mar 8, 2023
@miss-islington

miss-islington commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Sorry @kumaraditya303, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e499680100a9d4fa4b673cbcfebc32212b4f848a 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
06db319 
* main:
  pythongh-102304: Consolidate Direct Usage of _Py_RefTotal (pythongh-102514)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) (python#102218)
  pythongh-102507 Remove invisible pagebreak characters (python#102531)
  pythongh-102515: Remove unused imports in the `Lib/` directory (python#102516)
  Remove or update bitbucket links (pythonGH-101963)
  pythongh-101100: Fix sphinx warnings in `zipapp` and `zipfile` modules (python#102526)
  pythonGH-102397: Fix segfault from race condition in signal handling (python#102399)
  Fix style in argparse.rst (python#101733)
  Post 3.12.0a6
  fix typo in async generator code field name `ag_code` (python#102448)
  Python 3.12.0a6
@ZeroIntensity ZeroIntensity removed needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kumaraditya303 @AlexWaygood @miss-islington @bedevere-bot @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.