GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add gettext support to tools/extensions/c_annotations.py by remilapeyre · Pull Request #101989 · python/cpython

Conversation

@remilapeyre

@remilapeyre remilapeyre commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Rémi Lapeyre
Add gettext support to tools/extensions/c_annotations.py
42bf0bc
@bedevere-bot bedevere-bot added the awaiting review label Feb 17, 2023
@ghost

ghost commented Feb 17, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev added docs Documentation in the Doc dir skip issue skip news labels Feb 17, 2023
@arhadthedev
arhadthedev requested a review from encukou March 4, 2023 11:29
hugovk
hugovk approved these changes Mar 6, 2023
View reviewed changes

@hugovk hugovk left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this matches how internationalisation is done in https://github.com/python/cpython/blob/main/Doc/tools/extensions/pyspecific.py and will help localise pages like https://docs.python.org/ko/3/c-api/codec.html / https://deploy-preview-101989--python-cpython-preview.netlify.app/c-api/codec.html

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 6, 2023
@hugovk
hugovk merged commit d959bcd into python:main Mar 6, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 6, 2023
@hugovk hugovk added needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 6, 2023
@miss-islington

miss-islington commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 6, 2023

Copy link
Copy Markdown

GH-102480 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 6, 2023
@bedevere-bot

bedevere-bot commented Mar 6, 2023

Copy link
Copy Markdown

GH-102481 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 6, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 6, 2023
Rémi Lapeyre @miss-islington
Add gettext support to tools/extensions/c_annotations.py (pythonGH-10…
74f9ebf 
…1989)

(cherry picked from commit d959bcd)

Co-authored-by: Rémi Lapeyre <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 6, 2023
Rémi Lapeyre @miss-islington
Add gettext support to tools/extensions/c_annotations.py (pythonGH-10…
b55fc30 
…1989)

(cherry picked from commit d959bcd)

Co-authored-by: Rémi Lapeyre <[email protected]>
miss-islington added a commit that referenced this pull request Mar 6, 2023
@miss-islington Rémi Lapeyre
Add gettext support to tools/extensions/c_annotations.py (GH-101989)
4248c24 
(cherry picked from commit d959bcd)

Co-authored-by: Rémi Lapeyre <[email protected]>
miss-islington added a commit that referenced this pull request Mar 6, 2023
@miss-islington Rémi Lapeyre
Add gettext support to tools/extensions/c_annotations.py (GH-101989)
280b975 
(cherry picked from commit d959bcd)

Co-authored-by: Rémi Lapeyre <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Mar 7, 2023
@carljm
Merge branch 'main' into nodeaddict
e391218 
* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
1c019a7 
* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@remilapeyre @miss-islington @bedevere-bot @hugovk @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.