GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90110: Fix the c-analyzer Tool by ericsnowcurrently · Pull Request #102483 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Mar 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Some incompatible changes had gone in, and the "ignore" lists weren't properly undated. This change fixes that. It's necessary prior to enabling test_check_c_globals, which I hope to do soon.

Note that this does include moving last_resort_memory_error to PyInterpreterState.

  • Issue: Tools/c-analyzer is out-of-date. #90110

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 16 commits March 6, 2023 15:46
@ericsnowcurrently
Add Py_BUILD_CORE for some files.
71d7bd7
@ericsnowcurrently
Temporarily skip parser-failing files.
cf93eb5
@ericsnowcurrently
Optionally log the parser depth.
d50cb36
@ericsnowcurrently
Fix the GCC directives regex.
b94daf7
@ericsnowcurrently
Un-skip some of the files.
0bc1518
@ericsnowcurrently
Fix some ignored variables.
5154513
@ericsnowcurrently
Add an ignored variable.
5d16b2b
@ericsnowcurrently
Mark some variables as const.
37948f0
@ericsnowcurrently
Move last_resort_memory_error to PyInterpreterState.
0855962
@ericsnowcurrently
Ignore a few more globals.
688443e
@ericsnowcurrently
Add a global to the to-fix list.
95dddd9
@ericsnowcurrently
Ignore a global.
9af4fe1
@ericsnowcurrently
Ignore a bunch of test-only globals.
7da3804
@ericsnowcurrently
Ignore a global.
57f8bb1
@ericsnowcurrently
(gcc) __inline__ -> inline
332f883
@ericsnowcurrently
Fix the hash-related modules.
9f02087
@ericsnowcurrently ericsnowcurrently added the skip news label Mar 6, 2023
@ericsnowcurrently
ericsnowcurrently requested a review from iritkatriel as a code owner March 6, 2023 23:03
@bedevere-bot bedevere-bot mentioned this pull request Mar 6, 2023
Tools/c-analyzer is out-of-date. #90110
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 6, 2023
@ericsnowcurrently
ericsnowcurrently removed the request for review from iritkatriel March 6, 2023 23:04
@ericsnowcurrently
ericsnowcurrently merged commit 8606697 into python:main Mar 7, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 7, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-c-analyzer branch March 7, 2023 02:40
carljm added a commit to carljm/cpython that referenced this pull request Mar 7, 2023
@carljm
Merge branch 'main' into nodeaddict
e391218 
* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
1c019a7 
* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.