GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-95913: Edit Faster CPython section in 3.11 WhatsNew by CAM-Gerlach · Pull Request #98429 · python/cpython

Conversation

CAM-Gerlach commented Oct 19, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Part of #95913

This PR cross-references, sphinxifies and copyedits the Faster CPython section of the What's New in Python 3.11 document. Specifically, it:

Converts the FAQ from a manually formatted static block to standard, linkable headings and ref target labels
Adds Sphinx roles and cross references to the appropriate constructs missing them
Fixes and refines reST syntax
Refines some of the writing to improve readability and reduce choppiness
Fixes/tweaks a few other minor textual issues

Notably, it takes care not to make any substantive additions/changes to the actual content, to expedite review, as it already was assumed to be reasonably complete

Issue: Edit What's New for Python 3.11 #95913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add cross references and fix syntax for main sections

a7493eb

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Oct 19, 2022

CAM-Gerlach added 3 commits

October 18, 2022 23:30


          Add cross references and refine reST syntax in specialization table

5e67f8b


          Convert FAQ from manually-formatted to section headings + ref targets

2fda457


          Improve readibility/reduce choppiness & a few other textual tweaks

3d614ee

CAM-Gerlach force-pushed the whatsnew-faster-cpython branch from dced4fa to 3d614ee Compare

October 19, 2022 04:31

CAM-Gerlach added 3.11

only security fixes

needs backport to 3.11 only security fixes labels

Oct 19, 2022

CAM-Gerlach mentioned this pull request

Oct 19, 2022

Edit What's New for Python 3.11 #95913

Closed

31 of 33 tasks

Fidget-Spinner self-requested a review

October 19, 2022 11:32

Fidget-Spinner reviewed

Oct 19, 2022

View reviewed changes

Fidget-Spinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply textual clarifications from Ken Jin

6fe84e8

Co-authored-by: Ken Jin <[email protected]>

CAM-Gerlach requested a review from Fidget-Spinner

October 19, 2022 19:02

CAM-Gerlach mentioned this pull request

Oct 19, 2022

gh-95913: Edit & expand Optimizations in 3.11 WhatsNew #98426

Merged


          Add Brandt's pythongh-91404 regex speedup from Optimizations to Misc …

076e331

…section

mdboom requested a review from markshannon

October 19, 2022 21:12


          Add zero-cost exceptions moved from Optimization section

2b24d4e

CAM-Gerlach commented Mar 6, 2023

Copy link

Copy Markdown

Member Author

Hey @Fidget-Spinner , did you get a chance to give this another look?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Fidget-Spinner commented Mar 6, 2023

Copy link

Copy Markdown

Member

Oh gosh I'm so sorry that I forgot about this. Thanks for the ping.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          LOAD_GLOBAL without call

0e898cd

Co-authored-by: C.A.M. Gerlach <[email protected]>

Fidget-Spinner reviewed

Mar 6, 2023

View reviewed changes

Comment thread

Doc/whatsnew/3.11.rst

		others have sped up by nearly 2x!


		.. _faster-cpython-jit:

Fidget-Spinner Mar 6, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my own understanding, these are so that the hyperlink generates nicer links right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

CAM-Gerlach Mar 6, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are ref target labels, which allow directly and stably linking and cross-referencing of this FAQ answer using the :ref: role (:ref:`faster-cypthon-jit`), both within this document (as with implicit hyperlinks, but much more robustly), but also from anywhere else within the CPython documentation, and also from any other docs that links to this one via Intersphinx (as many do). This reference will continue to work even if this section is later moved, renamed, combined with another section, split into multiple, etc.

Furthermore, it means external links to this fragment id (i.e. using #faster-cpython-jit) will continue to work if the section is renamed on the same page, and it also allows automatically setting up external-link redirects to different pages via some tooling I'm working on. Finally, if it were to break for whatever reason, it will generate an optional warning rather than simply breaking silently.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Fidget-Spinner approved these changes

Mar 7, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Mar 7, 2023

Fidget-Spinner merged commit 80b19a3 into python:main

Mar 7, 2023

miss-islington commented Mar 7, 2023

Copy link

Copy Markdown

Contributor

Thanks @CAM-Gerlach for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Mar 7, 2023

bedevere-bot commented Mar 7, 2023

Copy link

Copy Markdown

GH-102490 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Mar 7, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 7, 2023


          pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonG…

1adcd12

…H-98429)

(cherry picked from commit 80b19a3)

Co-authored-by: C.A.M. Gerlach <[email protected]>

Fidget-Spinner pushed a commit that referenced this pull request

Mar 7, 2023


          [3.11] gh-95913: Edit Faster CPython section in 3.11 WhatsNew (GH-98429…

df3ed54

…) (GH-102490)

gh-95913: Edit Faster CPython section in 3.11 WhatsNew (GH-98429)
(cherry picked from commit 80b19a3)

Co-authored-by: C.A.M. Gerlach <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Mar 7, 2023


          Merge branch 'main' into nodeaddict

e391218

* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)

carljm added a commit to carljm/cpython that referenced this pull request

Mar 8, 2023


          Merge branch 'main' into inlinecomp2

1c019a7

* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)

Reviewers

Fidget-Spinner

Fidget-Spinner approved these changes

markshannon

Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.11

only security fixes

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

CAM-Gerlach commented Oct 19, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fidget-Spinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CAM-Gerlach commented Mar 6, 2023

Uh oh!

Fidget-Spinner commented Mar 6, 2023

Uh oh!

Fidget-Spinner Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Mar 7, 2023

Uh oh!

bedevere-bot commented Mar 7, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CAM-Gerlach commented Oct 19, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.