GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102493: fix normalization in PyErr_SetObject by iritkatriel · Pull Request #102502 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Mar 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #102493.

  • Issue: gh-101607 causes regression in third-party psutil package on macOS #102493

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 2 commits March 7, 2023 16:38
@iritkatriel
add test for PyErr_SetObject
077747d
@iritkatriel
fix normalization in PyErr_SetObject
feef425
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error release-blocker 3.12 only security fixes labels Mar 7, 2023
@iritkatriel
iritkatriel requested a review from markshannon March 7, 2023 16:43
@bedevere-bot bedevere-bot mentioned this pull request Mar 7, 2023
gh-101607 causes regression in third-party psutil package on macOS #102493
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 7, 2023
@iritkatriel
iritkatriel requested review from Yhg1s, giampaolo and ned-deily March 7, 2023 16:43
@iritkatriel
add news
c211d86
ned-deily
ned-deily reviewed Mar 7, 2023
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit about the NEWS blurb entry but otherwise I verified that the PR does fix the observed regression with psutil on macOS and that no new test suite regressions are observed. Thanks, @iritkatriel, for the fast work!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-03-07-16-56-28.gh-issue-102502.gTXrcD.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s
Yhg1s approved these changes Mar 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 7, 2023
@iritkatriel
rename news file
cea7ff9
ned-deily
ned-deily approved these changes Mar 7, 2023
View reviewed changes
@iritkatriel iritkatriel changed the title gh-102493: fix normalisation in PyErr_SetObject gh-102493: fix normalization in PyErr_SetObject Mar 7, 2023
JelleZijlstra
JelleZijlstra reviewed Mar 7, 2023
View reviewed changes
Comment thread Python/errors.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/errors.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum reviewed Mar 7, 2023
View reviewed changes
Comment thread Python/errors.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
assert not null
61c6615
JelleZijlstra
JelleZijlstra approved these changes Mar 7, 2023
View reviewed changes
iritkatriel and others added 2 commits March 7, 2023 19:03
@iritkatriel
skip issubclass when not an exception
a9094f9
@iritkatriel @JelleZijlstra
whitespace
6d7bccd 
Co-authored-by: Jelle Zijlstra <[email protected]>
gvanrossum
gvanrossum approved these changes Mar 7, 2023
View reviewed changes
Yhg1s
Yhg1s reviewed Mar 7, 2023
View reviewed changes
Comment thread Python/errors.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
fix refleak when is_subclass fails
fd01812
Yhg1s
Yhg1s approved these changes Mar 7, 2023
View reviewed changes
@Yhg1s
Yhg1s merged commit a33ca2a into python:main Mar 7, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 7, 2023
carljm added a commit to carljm/cpython that referenced this pull request Mar 7, 2023
@carljm
Merge branch 'main' into nodeaddict
e391218 
* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)
carljm added a commit to carljm/cpython that referenced this pull request Mar 8, 2023
@carljm
Merge branch 'main' into inlinecomp2
1c019a7 
* main:
  pythongh-102493: fix normalization in PyErr_SetObject (python#102502)
  pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320)
  pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781)
  Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398)
  pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429)
  pythongh-90110: Fix the c-analyzer Tool (python#102483)
  pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485)
  Remove unused import of `warnings` from `unittest.loader` (python#102479)
  Add gettext support to tools/extensions/c_annotations.py (python#101989)
@gvanrossum gvanrossum mentioned this pull request Mar 13, 2023
PyErr_SetObject() behavior is strange and not as documented. #101578
Closed
@iritkatriel
iritkatriel deleted the gh-102493 branch April 3, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes
@Yhg1s Yhg1s Yhg1s approved these changes
@ned-deily ned-deily ned-deily approved these changes
@markshannon markshannon Awaiting requested review from markshannon
@giampaolo giampaolo Awaiting requested review from giampaolo

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes release-blocker type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gh-101607 causes regression in third-party psutil package on macOS

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@iritkatriel @JelleZijlstra @gvanrossum @Yhg1s @ned-deily @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.