GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Improve grammar/fix missing word by vayidm · Pull Request #102060 · python/cpython

Conversation

vayidm commented Feb 20, 2023

Copy link

Copy Markdown

Contributor

I added one word in the logging cookbook that seemed to be missing, and updated the bugs reporting page. I haven't created an issue as the change seems to be trivial.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vayidm added 2 commits

February 20, 2023 00:45


          Improve sentence

e98a0cf


          Improve sentence

28f6168

Fewer is more suitable with countable nouns such as "words", see: https://www.grammarly.com/blog/fewer-vs-less/

vayidm requested a review from vsajip as a code owner

February 20, 2023 01:04

ghost commented Feb 20, 2023 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All commit authors signed the Contributor License Agreement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Feb 20, 2023

vsajip approved these changes

Feb 26, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Feb 26, 2023

vsajip added the skip issue label

Feb 26, 2023

vsajip merged commit 6daf42b into python:main

Feb 26, 2023

bedevere-bot removed the awaiting merge label

Feb 26, 2023

vsajip added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Feb 26, 2023

miss-islington commented Feb 26, 2023

Copy link

Copy Markdown

Contributor

Thanks @vayidm for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

vayidm reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Feb 26, 2023

Copy link

Copy Markdown

Contributor

Thanks @vayidm for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Feb 26, 2023

Copy link

Copy Markdown

GH-102277 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Feb 26, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 26, 2023


          [doc] Improve grammar/fix missing word (pythonGH-102060)

5e44a8f

(cherry picked from commit 6daf42b)

Co-authored-by: VMan <[email protected]>

bedevere-bot commented Feb 26, 2023

Copy link

Copy Markdown

GH-102278 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 26, 2023


          [doc] Improve grammar/fix missing word (pythonGH-102060)

d1d1497

(cherry picked from commit 6daf42b)

Co-authored-by: VMan <[email protected]>

bedevere-bot removed the needs backport to 3.10 label

Feb 26, 2023

vsajip pushed a commit that referenced this pull request

Feb 26, 2023


          [3.10] [doc] Improve grammar/fix missing word (GH-102060) (GH-102278)

4732f55

[doc] Improve grammar/fix missing word (GH-102060)
(cherry picked from commit 6daf42b)

Co-authored-by: VMan <[email protected]>

vsajip pushed a commit that referenced this pull request

Feb 26, 2023


          [3.11] [doc] Improve grammar/fix missing word (GH-102060) (GH-102277)

2c4fc87

[doc] Improve grammar/fix missing word (GH-102060)
(cherry picked from commit 6daf42b)

Co-authored-by: VMan <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Feb 28, 2023


          Merge branch 'main' into inlinecomp2

73dc0ed

* main: (67 commits)
  pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)
  pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)
  pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)
  pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309)
  Migrate to new PSF mailgun account (python#102284)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)
  pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)
  pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)
  pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102)
  IDLE: Simplify DynOptionsMenu __init__code (python#101371)
  pythongh-101561: Add typing.override decorator (python#101564)
  pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)
  pythongh-101773: Optimize creation of Fractions in private methods (python#101780)
  pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)
  pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)
  pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)
  pythongh-101100: Fix sphinx warnings in `types` module (python#102274)
  pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)
  pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283)
  [doc] Improve grammar/fix missing word (pythonGH-102060)
  ...

Reviewers

vsajip

vsajip approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vayidm commented Feb 20, 2023

Uh oh!

ghost commented Feb 20, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Feb 26, 2023

Uh oh!

miss-islington commented Feb 26, 2023

Uh oh!

bedevere-bot commented Feb 26, 2023

Uh oh!

bedevere-bot commented Feb 26, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ghost commented Feb 20, 2023 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.