GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-102296 Document that inspect.Parameter kinds support ordering by Gouvernathor · Pull Request #102297 · python/cpython

Conversation

Gouvernathor commented Feb 27, 2023 •

edited by miss-islington

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Documenting that inspect.Parameter.kind attributes support ordering #102296

Automerge-Triggered-By: GH:AlexWaygood

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Document that inspect.Parameter kinds support ordering

1c57acc

bedevere-bot added the awaiting review label

Feb 27, 2023

bedevere-bot mentioned this pull request

Feb 27, 2023

Documenting that inspect.Parameter.kind attributes support ordering #102296

Closed

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

Feb 27, 2023

AlexWaygood reviewed

Feb 27, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like we currently have any tests asserting that the inspect.Parameter kinds support ordering. I'm not sure we should document it if it's untested, as that means that it could break in the future without anybody noticing. Would you be interested in adding a test to https://github.com/python/cpython/blob/main/Lib/test/test_inspect.py as part of this PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Gouvernathor reacted with thumbs up emoji

All reactions

👍 1 reaction

Gouvernathor commented Feb 27, 2023

Copy link

Copy Markdown

Contributor Author

@AlexWaygood I was about to, but actually there is !

cpython/Lib/test/test_inspect.py

Lines 3725 to 3726 in e3c3f9f

	self.assertTrue(P.POSITIONAL_ONLY < P.POSITIONAL_OR_KEYWORD < \
	P.VAR_POSITIONAL < P.KEYWORD_ONLY < P.VAR_KEYWORD)

AlexWaygood reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Feb 27, 2023

Copy link

Copy Markdown

Member

@AlexWaygood I was about to, but actually there is !

cpython/Lib/test/test_inspect.py

Lines 3725 to 3726 in e3c3f9f

self.assertTrue(P.POSITIONAL_ONLY < P.POSITIONAL_OR_KEYWORD < \

P.VAR_POSITIONAL < P.KEYWORD_ONLY < P.VAR_KEYWORD)

Thanks, not sure how I missed that!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood reviewed

Feb 27, 2023

View reviewed changes

Comment thread

Doc/library/inspect.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Slightly more concise

94a4254

Co-authored-by: Alex Waygood <[email protected]>

AlexWaygood approved these changes

Feb 27, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Gouvernathor reacted with heart emoji

All reactions

❤️ 1 reaction

bedevere-bot added awaiting merge and removed awaiting review labels

Feb 27, 2023

AlexWaygood added 🤖 automerge needs backport to 3.11 only security fixes labels

Feb 27, 2023

miss-islington commented Feb 27, 2023

Copy link

Copy Markdown

Contributor

Status check is done, and it's a success ✅.

Gouvernathor reacted with rocket emoji

All reactions

🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington merged commit 0db6f44 into python:main

Feb 27, 2023

bedevere-bot removed the awaiting merge label

Feb 27, 2023

miss-islington commented Feb 27, 2023

Copy link

Copy Markdown

Contributor

Thanks @Gouvernathor for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

Gouvernathor reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Feb 27, 2023

Copy link

Copy Markdown

GH-102298 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Feb 27, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 27, 2023


          pythongh-102296 Document that inspect.Parameter kinds support ordering (

0ca662e

pythonGH-102297)

(cherry picked from commit 0db6f44)

Co-authored-by: Gouvernathor <[email protected]>
Automerge-Triggered-By: GH:AlexWaygood

bedevere-bot commented Feb 27, 2023

Copy link

Copy Markdown

GH-102299 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 27, 2023


          pythongh-102296 Document that inspect.Parameter kinds support ordering (

b686291

pythonGH-102297)

(cherry picked from commit 0db6f44)

Co-authored-by: Gouvernathor <[email protected]>
Automerge-Triggered-By: GH:AlexWaygood

bedevere-bot removed the needs backport to 3.10 label

Feb 27, 2023

Gouvernathor deleted the patch-3 branch

February 27, 2023 15:17

miss-islington added a commit that referenced this pull request

Feb 27, 2023


          gh-102296 Document that inspect.Parameter kinds support ordering (GH-…

1ef6e45

…102297)

(cherry picked from commit 0db6f44)

Co-authored-by: Gouvernathor <[email protected]>
Automerge-Triggered-By: GH:AlexWaygood

miss-islington added a commit that referenced this pull request

Feb 27, 2023


          gh-102296 Document that inspect.Parameter kinds support ordering (GH-…

ca1cc14

…102297)

(cherry picked from commit 0db6f44)

Co-authored-by: Gouvernathor <[email protected]>
Automerge-Triggered-By: GH:AlexWaygood

carljm added a commit to carljm/cpython that referenced this pull request

Feb 28, 2023


          Merge branch 'main' into inlinecomp2

73dc0ed

* main: (67 commits)
  pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)
  pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)
  pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)
  pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309)
  Migrate to new PSF mailgun account (python#102284)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)
  pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)
  pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)
  pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102)
  IDLE: Simplify DynOptionsMenu __init__code (python#101371)
  pythongh-101561: Add typing.override decorator (python#101564)
  pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)
  pythongh-101773: Optimize creation of Fractions in private methods (python#101780)
  pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)
  pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)
  pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)
  pythongh-101100: Fix sphinx warnings in `types` module (python#102274)
  pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)
  pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283)
  [doc] Improve grammar/fix missing word (pythonGH-102060)
  ...

Reviewers

AlexWaygood

AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Gouvernathor commented Feb 27, 2023 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Gouvernathor commented Feb 27, 2023

Uh oh!

AlexWaygood commented Feb 27, 2023

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Feb 27, 2023

Uh oh!

miss-islington commented Feb 27, 2023

Uh oh!

bedevere-bot commented Feb 27, 2023

Uh oh!

bedevere-bot commented Feb 27, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gouvernathor commented Feb 27, 2023 •

edited by miss-islington

Loading

Uh oh!

There was an error while loading. Please reload this page.