GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91038: Change default argument value to `False` instead of `0` by Rotzbua · Pull Request #31621 · python/cpython

Conversation

@Rotzbua

@Rotzbua Rotzbua commented Feb 28, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The argument is used as a switch and corresponds to a boolean logic. Therefore it is more intuitive to use the corresponding constant False as default value instead of the integer 0.

https://bugs.python.org/issue46882

  • Issue: Clarify argument type of platform.platform(aliased, terse) to boolean #91038

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Rotzbua
Change default argument value to False instead of 0
513d84d 
The argument is used as a switch and corresponds to a boolean logic. Therefore it is more intuitive to use the corresponding constant `False` as default value instead of the integer `0`.
@bedevere-bot bedevere-bot added the awaiting review label Feb 28, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 28, 2022
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@JelleZijlstra JelleZijlstra self-assigned this Oct 6, 2022
JelleZijlstra
JelleZijlstra requested changes Oct 6, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is an improvement, but I think it deserves a NEWS entry. Could you add one?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting review label Oct 6, 2022
@bedevere-bot

bedevere-bot commented Oct 6, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Oct 6, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request Oct 6, 2022
bpo-46882: Clarify argument type of platform.platform(aliased, terse) to boolean #31617
Closed
@JelleZijlstra JelleZijlstra removed their assignment Nov 12, 2022
@hauntsaninja
Merge branch 'main' into change_default_value_platform_platform
9382424
@bedevere-bot

bedevere-bot commented Feb 26, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev changed the title bpo-46882: Change default argument value to False instead of 0 gh-91038: Change default argument value to False instead of 0 Feb 26, 2023
@arhadthedev arhadthedev added docs Documentation in the Doc dir stdlib Standard Library Python modules in the Lib/ directory labels Feb 26, 2023
@arhadthedev
Add a news entry
5de86dd
@arhadthedev
arhadthedev requested a review from JelleZijlstra February 26, 2023 08:38
@arhadthedev

arhadthedev commented Feb 26, 2023

Copy link
Copy Markdown
Member

@JelleZijlstra I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Feb 27, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Feb 27, 2023
@JelleZijlstra
JelleZijlstra merged commit f3cb15c into python:main Feb 27, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 27, 2023
@Rotzbua Rotzbua mannequin mentioned this pull request Apr 10, 2022
Clarify argument type of platform.platform(aliased, terse) to boolean #91038
Closed
carljm added a commit to carljm/cpython that referenced this pull request Feb 28, 2023
@carljm
Merge branch 'main' into inlinecomp2
73dc0ed 
* main: (67 commits)
  pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)
  pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)
  pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)
  pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309)
  Migrate to new PSF mailgun account (python#102284)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)
  pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)
  pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)
  pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102)
  IDLE: Simplify DynOptionsMenu __init__code (python#101371)
  pythongh-101561: Add typing.override decorator (python#101564)
  pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)
  pythongh-101773: Optimize creation of Fractions in private methods (python#101780)
  pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)
  pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)
  pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)
  pythongh-101100: Fix sphinx warnings in `types` module (python#102274)
  pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)
  pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283)
  [doc] Improve grammar/fix missing word (pythonGH-102060)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Rotzbua @bedevere-bot @arhadthedev @JelleZijlstra @the-knights-who-say-ni @ezio-melotti @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.