GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) by iritkatriel · Pull Request #102193 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Feb 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR does most of Python/.

  • Issue: Replace Fetch/Restore etc by the new exception APIs #102192

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
iritkatriel requested review from markshannon and methane as code owners February 23, 2023 23:19
@bedevere-bot bedevere-bot added the awaiting core review label Feb 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2023
Replace Fetch/Restore etc by the new exception APIs #102192
Closed
@iritkatriel iritkatriel added the skip news label Feb 23, 2023
@iritkatriel

iritkatriel commented Feb 23, 2023

Copy link
Copy Markdown
Member Author

Skipping news because these are internal-only changes, and the fact of PyErr_Fetch/Restore being obsolete is already in the news.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@bedevere-bot

bedevere-bot commented Feb 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 9abebe0 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@iritkatriel iritkatriel changed the title gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (Objects/ and Python/) Feb 24, 2023
@iritkatriel
iritkatriel requested a review from erlend-aasland February 24, 2023 00:53
@iritkatriel

iritkatriel commented Feb 24, 2023

Copy link
Copy Markdown
Member Author

There's a refcount issue somewhere. Checking.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Feb 24, 2023
View reviewed changes
Comment thread Objects/exceptions.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

I must say this is a great improvement in readability. The new API is indeed a better API. Thanks!
iritkatriel reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel mentioned this pull request Feb 24, 2023
gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Objects/) #102218
Merged
iritkatriel added 7 commits February 24, 2023 21:44
@iritkatriel
Python/ceval.c
1a5cae1
@iritkatriel
Python/ceval_gil.c
10738bf
@iritkatriel
Python/frame.c
71d2958
@iritkatriel
Python/sysmodule.c
3c4bdd8
@iritkatriel
Python/compile.c
30832e9
@iritkatriel
Python/modsupport.c
694da1b
@iritkatriel
Python/initconfig.c
b5150cc
@iritkatriel
iritkatriel force-pushed the fetch-restore branch from 9abebe0 to b5150cc Compare February 24, 2023 21:44
@iritkatriel iritkatriel changed the title gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (Objects/ and Python/) gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) Feb 24, 2023
@iritkatriel
Merge branch 'main' into fetch-restore
603922d
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@bedevere-bot

bedevere-bot commented Feb 24, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 603922d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@iritkatriel
Merge branch 'main' into fetch-restore
df86e20
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 25, 2023
@bedevere-bot

bedevere-bot commented Feb 25, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit df86e20 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 25, 2023
@iritkatriel
Merge branch 'main' into fetch-restore
f29ca0b
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 26, 2023
@bedevere-bot

bedevere-bot commented Feb 26, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit f29ca0b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 26, 2023
@iritkatriel

iritkatriel commented Feb 27, 2023

Copy link
Copy Markdown
Member Author

There's only one failure now, in an AMD64 RHEL7 builedbot which has been flaky for a couple of months. I'll call it a pass.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Feb 28, 2023

Copy link
Copy Markdown
Member Author

There's only one failure now, in an AMD64 RHEL7 builedbot

It passes now, so this PR should be fine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon requested changes Feb 28, 2023
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor edit needed, otherwise LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/ceval.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Feb 28, 2023
@bedevere-bot

bedevere-bot commented Feb 28, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon approved these changes Feb 28, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Feb 28, 2023
@iritkatriel
iritkatriel merged commit 4c87537 into python:main Feb 28, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 28, 2023
carljm added a commit to carljm/cpython that referenced this pull request Feb 28, 2023
@carljm
Merge branch 'main' into inlinecomp2
73dc0ed 
* main: (67 commits)
  pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)
  pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)
  pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)
  pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309)
  Migrate to new PSF mailgun account (python#102284)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)
  pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)
  pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)
  pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102)
  IDLE: Simplify DynOptionsMenu __init__code (python#101371)
  pythongh-101561: Add typing.override decorator (python#101564)
  pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)
  pythongh-101773: Optimize creation of Fractions in private methods (python#101780)
  pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)
  pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)
  pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)
  pythongh-101100: Fix sphinx warnings in `types` module (python#102274)
  pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)
  pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283)
  [doc] Improve grammar/fix missing word (pythonGH-102060)
  ...
@iritkatriel
iritkatriel deleted the fetch-restore branch April 3, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@markshannon markshannon markshannon approved these changes
@methane methane Awaiting requested review from methane

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @bedevere-bot @erlend-aasland @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.