GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-84436 Add integration C API tests for immortal objects by corona10 · Pull Request #103962 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Apr 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Got motivation from #103922 (comment)
This PR is not the answer to the need for emulation mode but for minimum verification.

  • Issue: Fixing Copy on Writes from reference counting and immortal objects #84436

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@corona10
corona10 requested review from JelleZijlstra, erlend-aasland and iritkatriel April 28, 2023 02:13
@corona10
corona10 requested a review from a team as a code owner April 28, 2023 02:13
@bedevere-bot bedevere-bot mentioned this pull request Apr 28, 2023
Fixing Copy on Writes from reference counting and immortal objects #84436
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 28, 2023
corona10
corona10 commented Apr 28, 2023
View reviewed changes
Comment thread PCbuild/_testcapi.vcxproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10 corona10 added the skip news label Apr 28, 2023
@corona10
corona10 force-pushed the gh-84436-objects branch from 7adb521 to b8451a5 Compare April 28, 2023 02:22
erlend-aasland
erlend-aasland reviewed Apr 28, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look on my phone. I'll take a better look later today.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 requested a review from erlend-aasland April 28, 2023 05:48
erlend-aasland
erlend-aasland reviewed Apr 28, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some more comments on test_immortal_bool. The same comments applies to the rest of the test functions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 requested a review from erlend-aasland April 28, 2023 11:26
@JelleZijlstra JelleZijlstra changed the title gh-84436 Add intergration C API tests for immortal objects gh-84436 Add integration C API tests for immortal objects Apr 29, 2023
@corona10

corona10 commented Apr 30, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland @JelleZijlstra @iritkatriel
If there is no major objection, I prefer to merge this PR by next week.
I expect that if the more immortal type is added, more test cases will be added here.

erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 force-pushed the gh-84436-objects branch from 5b3447a to a3df017 Compare May 2, 2023 03:38
erlend-aasland
erlend-aasland reviewed May 2, 2023
View reviewed changes
Comment thread Modules/_testcapi/immortal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

corona10 and others added 13 commits May 2, 2023 19:13
@corona10
pythongh-84436 Add intergration C API tests for immortal objects
644e883
@corona10
Update PCbuild/_testcapi.vcxproj
2eea452
@corona10
Windows format
1c70211
@corona10
Add immortal.c
6a83bae
@corona10
Add test_immortal.py
94ca054
@corona10
fix format
73daa12
@corona10
make patchcheck
e5b8e45
@corona10
fix format
2f4ee5f
@corona10
address code review
55a394b
@corona10
Adjust small int range
4fb6719
@corona10
Address code review
e737489
@corona10
nit
b03def1
@corona10
Address code review
e0295b5
@corona10
corona10 force-pushed the gh-84436-objects branch from a3df017 to e0295b5 Compare May 2, 2023 10:14
@corona10
Refactor test codes and fix test_immortal.py
5538ed4
@corona10
corona10 requested a review from erlend-aasland May 2, 2023 10:22
@corona10

corona10 commented May 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Merge this PR. If there needs some improvement, please let me know!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 merged commit d81ca7e into python:main May 2, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 2, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 2, 2023
@carljm
Merge branch 'main' into inlinecomp2
0727d6f
* main:
  pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)
  pythongh-65022: Fix description of tuple return value in copyreg (python#103892)
  pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)
  pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)
  pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)
  pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)
  pythonGH-103484: Fix redirected permanently URLs (python#104001)
  Improve assert_type phrasing (python#104081)
  pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)
  pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)
  pythongh-88496: IDLE - fix another test on macOS (python#104075)
  pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)
  pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)
  pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
@corona10
corona10 deleted the gh-84436-objects branch May 2, 2023 21:59
carljm added a commit to carljm/cpython that referenced this pull request May 2, 2023
@carljm
Merge branch 'main' into cached_property_docs
b9c39e3
* main: (760 commits)
  pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103)
  pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105)
  pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)
  pythongh-65022: Fix description of tuple return value in copyreg (python#103892)
  pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)
  pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)
  pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)
  pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)
  pythonGH-103484: Fix redirected permanently URLs (python#104001)
  Improve assert_type phrasing (python#104081)
  pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)
  pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)
  pythongh-88496: IDLE - fix another test on macOS (python#104075)
  pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)
  pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)
  pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  ...
@skirpichev skirpichev mentioned this pull request Mar 13, 2026
gh-143050: correct PyLong_FromString() to use _PyLong_Negate() #145901
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra
@iritkatriel iritkatriel Awaiting requested review from iritkatriel
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@corona10 @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.