GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-104057: Fix direct invocation of test_super by Eclips4 · Pull Request #104064 · python/cpython

Conversation

Eclips4 commented May 1, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

PS C:\Users\KIRILL-1\CLionProjects\cpython> ./python Lib/test/test_super.py            
Running Debug|x64 interpreter...
.................EE............
======================================================================
ERROR: test_shadowed_dynamic (__main__.TestSuper.test_shadowed_dynamic)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\KIRILL-1\CLionProjects\cpython\Lib\test\test_super.py", line 363, in test_shadowed_dynamic
    self.assertEqual(C().method(), "super super")
                     ^^^^^^^^^^^^
  File "C:\Users\KIRILL-1\CLionProjects\cpython\Lib\test\test_super.py", line 360, in method
    return super().msg
           ^^^^^^^^^^^
AttributeError: 'super' object has no attribute 'msg'

======================================================================
ERROR: test_shadowed_dynamic_two_arg (__main__.TestSuper.test_shadowed_dynamic_two_arg)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\KIRILL-1\CLionProjects\cpython\Lib\test\test_super.py", line 377, in test_shadowed_dynamic_two_arg
    self.assertEqual(C().method(), "super super")
                     ^^^^^^^^^^^^
  File "C:\Users\KIRILL-1\CLionProjects\cpython\Lib\test\test_super.py", line 374, in method
    return super(1, 2).msg
           ^^^^^^^^^^^^^^^
TypeError: super() argument 1 must be a type, not int

----------------------------------------------------------------------
Ran 31 tests in 0.040s

FAILED (errors=2)

After fix, error will disappear.

Issue: Some test modules fail when run as a script #104057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-104057: Fix path

b40f33c

bedevere-bot added the awaiting review label

May 1, 2023

bedevere-bot mentioned this pull request

May 1, 2023

Some test modules fail when run as a script #104057

Closed

bedevere-bot added the tests Tests in the Lib/test dir label

May 1, 2023

carljm added the skip news label

May 1, 2023

carljm approved these changes

May 1, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

May 1, 2023

carljm merged commit 605f878 into python:main

May 1, 2023

bedevere-bot removed the awaiting merge label

May 1, 2023

Eclips4 deleted the fix_test_super branch

May 1, 2023 22:30

carljm added a commit to carljm/cpython that referenced this pull request

May 1, 2023


          Merge branch 'main' into inlinecomp2

1274e2b

* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request

May 1, 2023


          pythongh-104057: Fix direct invocation of test_super (python#104064)

ace23be

Signed-off-by: Pablo Galindo <[email protected]>

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request

May 1, 2023


          pythongh-104057: Fix direct invocation of test_super (python#104064)

cf9f75f

Signed-off-by: Pablo Galindo <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

May 2, 2023


          Merge branch 'main' into cached_property_docs

b9c39e3

* main: (760 commits)
  pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103)
  pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105)
  pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)
  pythongh-65022: Fix description of tuple return value in copyreg (python#103892)
  pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)
  pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)
  pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)
  pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)
  pythonGH-103484: Fix redirected permanently URLs (python#104001)
  Improve assert_type phrasing (python#104081)
  pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)
  pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)
  pythongh-88496: IDLE - fix another test on macOS (python#104075)
  pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)
  pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)
  pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  ...

Reviewers

carljm

carljm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Eclips4 commented May 1, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Eclips4 commented May 1, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.